LGTM, thanks. -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Zhigang Gong Sent: Tuesday, October 29, 2013 1:34 PM To: [email protected] Cc: Zhigang Gong Subject: [Beignet] [PATCH] GBE: enable bitselect vector builtin functions.
Now we have the scalar version of bitselect, so we enable the vector version in the def file. Also remove some comments. Signed-off-by: Zhigang Gong <[email protected]> --- backend/src/builtin_vector_proto.def | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/backend/src/builtin_vector_proto.def b/backend/src/builtin_vector_proto.def index 2b8f913..de816ce 100644 --- a/backend/src/builtin_vector_proto.def +++ b/backend/src/builtin_vector_proto.def @@ -229,7 +229,6 @@ intn isless (floatn x, floatn y) longn isless (doublen x, doublen y) intn islessequal (floatn x, floatn y) longn islessequal (doublen x, doublen y) -# XXX not implemented intn islessgreater (floatn x, floatn y) longn islessgreater (doublen x, doublen y) intn isfinite (floatn @@ -240,18 +239,15 @@ intn isnan (floatn) longn isnan (doublen) intn isnormal (floatn) longn isnormal (doublen) -# XXX not implemented intn isordered (floatn x, floatn y) longn isordered (doublen x, doublen y) -# XXX not implemented intn isunordered (floatn x, floatn y) longn isunordered (doublen x, doublen y) intn signbit (floatn) longn signbit (doublen) int any (igentype x) int all (igentype x) -# XXX need to revisit select latter -#gentype bitselect (gentype a, gentype b, gentype c) +gentype bitselect (gentype a, gentype b, gentype c) gentype select (gentype a, gentype b, igentype c) gentype select (gentype a, gentype b, ugentype c) -- 1.7.9.5 _______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet
