hi simon, thanks for your suggestion. I'll fix that in the next patchset.
> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On > Behalf Of Simon Richter > Sent: Saturday, September 28, 2013 12:04 PM > To: [email protected] > Subject: Re: [Beignet] [PATCH 2/3] add clCreateBufferFromLibva() api > > Hi, > > > This patch and the following patch is to introduce new API to cl lib. > > It's better to put it into include/CL/cl_intel.h, and the naming rule > > is to follow other non-standard API : clMapBufferIntel(cl_mem, > > cl_int*); clXXXIntel. > > In addition, extension functions need to be listed in the resolver function > clGetExtensionFunctionAddress (also in cl_api.c), so the extension function is > available when going through the ICD loader (which is also the reason for the > "Intel" suffix -- so the loader knows which resolver to call). > > Simon > _______________________________________________ > Beignet mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet
