LGTM
-----Original Message-----
From: [email protected] 
[mailto:[email protected]] On Behalf 
Of Zhigang Gong
Sent: Monday, September 02, 2013 11:29 AM
To: [email protected]
Subject: Re: [Beignet] [PATCH] GBE: We should set no predication/mask for EOT 
preparation.

ping for comments.

On Thu, Aug 29, 2013 at 02:35:01PM +0800, Zhigang Gong wrote:
> Signed-off-by: Zhigang Gong <[email protected]>
> ---
>  backend/src/backend/gen_context.cpp |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/backend/src/backend/gen_context.cpp 
> b/backend/src/backend/gen_context.cpp
> index a029719..f5ba8d8 100644
> --- a/backend/src/backend/gen_context.cpp
> +++ b/backend/src/backend/gen_context.cpp
> @@ -863,11 +863,11 @@ namespace gbe
>    }
>  
>    void GenContext::emitEotInstruction(const SelectionInstruction &insn) {
> -    p->MOV(GenRegister::ud8grf(112, 0), GenRegister::ud8grf(0, 0));
>      p->push();
>        p->curr.predicate = GEN_PREDICATE_NONE;
> -      p->curr.execWidth = 8;
>        p->curr.noMask = 1;
> +      p->MOV(GenRegister::ud8grf(112, 0), GenRegister::ud8grf(0, 0));
> +      p->curr.execWidth = 8;
>        p->EOT(112);
>      p->pop();
>    }
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Beignet mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/beignet
_______________________________________________
Beignet mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/beignet
_______________________________________________
Beignet mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/beignet

Reply via email to