possible improvement(s)

[Yacketta, Ronald]

Hello All,

I am sure someone out their in Perl land can offer a better solution
to the following.

        ###
        ###     slurp in all the required data for the report
        ###
        open ($LOG,"cat $g_logdir/OrderServer-*.log|")
                or die ( "Unable to open $g_logdir/OrderServer-*.log :
                $!");


as well as this

                ###
                ###     Capture specific errors
                ###
                if( $_ =~ /^<$g_date.*Throw|Orphan/ && $_ !~ /Throwing/) {
                        $err2033++ if ( $_ =~ /error 2033/);    # MQGET error's
                        $errEMPL++ if ( $_ =~ /Number: 6048/);  # EMPL NOT ON 
SALES/REP TABLE
                        $errMASTER++ if ( $_ =~ /Number: 50/);  # MASTER ORDER NUMBER 
ALREADY IN USE
                        $tmp++;                                 # All errors
                        # Capture the error message for DB insertion later
                        push( @errors, $1) if ( $_ =~ /^<$g_date.*Reason: (.*)/);
                }

                ###
                ###     Count number of successful order submits
                ###
                if ( $_ =~ /^<$g_date.*Units <(.*)> Submitted successfully/) {
                        $Units{$1}++;
                        $success++;
                        $totalUnits += $1;
                        $above4++ if ( $1 > 4 );
                }

-- 
Regards,
 Ronald                          mailto:[EMAIL PROTECTED]

-- 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]