On Sunday 12 April 2009 02:59:35 Dan Langille wrote: > Folks: > > To get Bacula 2.5.42-b2 to run on FreeBSD 7.x and 8.x, the following > patches are required. This is because a newer gcc is used on those > platforms. > > FYI: > > FreeBSD 6.3 - gcc 3.4.6 > FreeBSD 7.1 - gcc 4.2.1 > FreeBSD 8.x - gcc 4.2.1 (20070719) > > The patches relate to casting. These patches will be applied to the > FreeBSD port sysutils/bacula-server-devel (i.e. the beta port). When I > start working on Bacula 3.x version, I expect I'll need to apply similar > patches. > > If this makes sense to put into the Bacula source code, I'll commit it. > > See attached.
Each problem area needs to be looked at in detail. The patches you show might work for FreeBSD, but in general they are not totally correct -- for example within Bacula %d and %ld are identical so we do not use %ld. Also in general long and int on most machines are identical so we refrain from using long. The solution is not always so obviously unless one has carefully studied the Bacula printf routines. Sometimes there is no satisfactory solution so we implement an unsatisfactory one. There are a number of really wasteful and stupid cases of where char * and const char * casting is needed on versions of g++ 4.3 and greater (we are using 4.2), but they need to be dealt with individually. Some need casting and others need subroutine argument changes. Many (most) have been already fixed in 3.0.0. If you have either warning messages or hard compiler errors, the best solution, IMO, is for you to send us a proposed patch, and we will tweak it appropriately (hopefully) and let you try it. If it works, great. If not we can iterate until it works. Does that sound OK? Regards, Kern ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
