On Thu, Nov 10, 2011 at 10:32 AM, James Jenner <[email protected]>wrote:
> > > I don't like how the lens are looking for 11.10 in unity so I made come >> mock ups. >> >> > I think all the mockups give the impression that selection of the lens > directly affects the search bar, while not making it apparent that the > whole lens area is affected. Overall though I think I like the second one > the best, the other two will suffer as more lenses are added but do utilise > the screen better. > > I don't mind the control at the top, which to me would make more sense as > you have just selected the lens launcher and thus the lens selection is on > the same level, kinda consistent with applications that have window > controls or application controls along the top. In my mind, the lens > selection should be near the top, not at the bottom (though maybe for a > touch screen it's irrelevant as you would swipe between lenses I presume). > > Do you mind if I ask how you did the mockups? Do you just use The Gimp? > > Cheers, > James. > > _______________________________________________ > Mailing list: https://launchpad.net/~ayatana > Post to : [email protected] > Unsubscribe : https://launchpad.net/~ayatana > More help : https://help.launchpad.net/ListHelp > > I like them on the top too! I suggested this a while back ( https://lists.launchpad.net/ayatana/msg06884.html) and got a slightly warm response.I went ahead and made a patch to unity that puts the bar on top.(see mockup) I mailed the diff to the ayatana-dev mailling list but have got no response till now. I've attached a screen shot and the diff.
<<attachment: LensBarToTop.jpg>>
=== modified file 'plugins/unityshell/src/DashView.cpp'
--- plugins/unityshell/src/DashView.cpp 2011-10-25 16:32:49 +0000
+++ plugins/unityshell/src/DashView.cpp 2011-11-07 12:40:23 +0000
@@ -119,6 +119,10 @@
search_bar_->search_changed.connect(sigc::mem_fun(this, &DashView::OnSearchChanged));
search_bar_->live_search_reached.connect(sigc::mem_fun(this, &DashView::OnLiveSearchReached));
search_bar_->showing_filters.changed.connect([&] (bool showing) { if (active_lens_view_) active_lens_view_->filters_expanded = showing; QueueDraw(); });
+
+ lens_bar_ = new LensBar();
+ lens_bar_->lens_activated.connect(sigc::mem_fun(this, &DashView::OnLensBarActivated));
+ content_layout_->AddView(lens_bar_, 0, nux::MINOR_POSITION_CENTER);
content_layout_->AddView(search_bar_, 0, nux::MINOR_POSITION_LEFT);
lenses_layout_ = new nux::VLayout();
@@ -128,10 +132,6 @@
active_lens_view_ = home_view_;
lens_views_["home.lens"] = home_view_;
lenses_layout_->AddView(home_view_);
-
- lens_bar_ = new LensBar();
- lens_bar_->lens_activated.connect(sigc::mem_fun(this, &DashView::OnLensBarActivated));
- content_layout_->AddView(lens_bar_, 0, nux::MINOR_POSITION_CENTER);
}
void DashView::SetupUBusConnections()
_______________________________________________ Mailing list: https://launchpad.net/~ayatana Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
