On Tue, Jan 18, 2022 at 10:01 AM Mike Frysinger <vap...@gentoo.org> wrote:
> On 31 May 2018 22:44, Jefferson Carpenter wrote:
> > Subject: [PATCH] automake.texi: clarify relationship between configure and
> > build dir
> >
> > I know you what this meant, but as a kid this would have confused me - the
> > word "in" seems to imply that the "configure" file is inside of the build
> > dir,
> > as if it should be copied there or something. The word "from" makes it more
> > clear that the intended action is to run "../configure" (or more generally
> > "$SOURCE_DIR/configure") from the build dir.
> >
> > --- a/doc/automake.texi
> > +++ b/doc/automake.texi
> > @@ -866,7 +866,7 @@ The source tree is rooted in the directory containing
> > @file{configure}. It contains all the sources files (those that are
> > distributed), and may be arranged using several subdirectories.
> >
> > -The build tree is rooted in the directory in which @file{configure}
> > +The build tree is rooted in the directory from which @file{configure}
> > was run, and is populated with all object files, programs, libraries,
> > and other derived files built from the sources (and hence not
> > distributed). The build tree usually has the same subdirectory layout
>
> thanks for the patch. it looks like Karl took inspiration from your
> suggestion
> and applied a fix to use "rooted in the current directory at the time
> configure"
> phrasing instead. i don't see a response in the group about it, so this is
> more
> of an FYI :).
> http://git.savannah.gnu.org/cgit/automake.git/commit/?h=8e05f006415d1811785ab5dab1ea4ae5a44c184e
Thanks for going through old patches.
In general, if one of the maintainers writes a diff and does not
attribute any other source, one can almost always assume they wrote
the diff independently. I.e., if Karl or I took inspiration from a bug
report, we would attribute it in the commit log. Giving credit where
due is important, so we try to be diligent about it. Unfortunately, I
have not read enough of the old submitted diffs.
