Peter, Thanks for all the suggestions!
> However, ideally I think you should plagiarize the test t/compile4.sh so that > we also test the wrapping of the icl compiler when it is available. You will > need to patch the require_tool function in t/ax/am-test-lib.sh to recognize > this "new" icl tool for that to work. The new patch adds t/compile7.sh which is a copy of t/compile4.sh, but with icl instead of cl. If there is a better way to avoid the code duplication I'd be more than willing to do it that way. Also, I've patched t/ax/am-test-lib.sh to recognize icl. > You are also missing a changelog * lib/compile: Have icl be treated similarly to cl * t/ax/am-test-lib.sh: Allow icl in require_tool * t/compile7.sh: Add new test file for icl * t/list-of-tests.mk: Add t/compile7.sh > and you need to update the scriptversion at the top of the compile script. Done. > You could also write the case match as... Done. > Since you send this from an intel account, why is it that -c -o isn't > supported? Icl is intended to be a drop in replacement for cl. So it has the same interface as cl. >And another question is if icl supports the -showIncludes option from MSVC? It does and works how it is in depcomp. -- Johnny -----Original Message----- From: Peter Rosin [mailto:p...@lysator.liu.se] Sent: Tuesday, November 17, 2015 8:07 AM To: Peyton, Jonathan L; automake-patches@gnu.org Subject: Re: Adding icl to compile wrapper script Hi Jonathan, On 2015-11-16 17:44, Peyton, Jonathan L wrote: > Hello automake developers, > > I have this patch which adds icl (Windows Intel Compiler) to the lib/compile > wrapper script. Icl has a Visual Studio driver interface and supports all > the flags that are translated inside the compile script. It also doesn't > support the '-o -c' idiom similar to the Visual Studio compiler so I think it > is a good candidate for this wrapper script. > > -- Johnny Yes, that sounds usable. However, ideally I think you should plagiarize the test t/compile4.sh so that we also test the wrapping of the icl compiler when it is available. You will need to patch the require_tool function in t/ax/am-test-lib.sh to recognize this "new" icl tool for that to work. You are also missing a changelog and you need to update the scriptversion at the top of the compile script. You could also write the case match as cl | *[/\\]cl | cl.exe | *[/\\]cl.exe \ icl | *[/\\]icl | icl.exe | *[/\\]icl.exe ) in order to not duplicate the code. Since you send this from an intel account, why is it that -c -o isn't supported? And another question is if icl supports the -showIncludes option from MSVC? Or does it have a way of its own to output dependencies? You might want to support a one-pass mode to find dependencies in the lib/depcomp script. Cheers, Peter
add-icl-to-compile-script-v2.patch
Description: add-icl-to-compile-script-v2.patch
