On 05/29/2013 12:36 AM, Peter Rosin wrote:
> On 2013-05-28 21:29, Stefano Lattarini wrote:
>> Hi Peter.
>>
>> On 05/28/2013 09:09 PM, Peter Rosin wrote:
>>> On 2013-05-28 20:10, Stefano Lattarini wrote:
>>>> + <http://austingroupbugs.net/view.php?id=542>7
>>>
>>> You have a mysterious trailing 7 here...
>>>
>>> Cheers,
>>> Peter
>>>
>> Oops, will remove. Thanks.
>>
>> BTW, I plan to release the beta for 1.13.3 tomorrow (planned
>> release: 3 June) and the beta for 1.14 tomorrow or the day
>> after (planned release: ~ 20 June). So if you find something
>> fishy in NEWS,
>
> I did a quick read if NEWS in the master branch, and I wanted these
> changes:
>
> diff --git a/NEWS b/NEWS
> index 5172150..6355bec 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -6,7 +6,7 @@ New in 2.0:
> object will *always* be put into the subdirectory named after the source
> file, rather than in the current directory. For instance, 'src/file.c'
> and 'src/file.f90' will be compiled to 'src/file.o', and 'sub/dir/mu.cc'
> - will be compiled to 'sub/dir/mu.o'. Put in another way, Automake 1.14
> + will be compiled to 'sub/dir/mu.o'. Put in another way, Automake 2.0
> and later will *unconditionally* behave as older Automake versions did
> when the 'subdir-objects' option was given.
>
> @@ -19,7 +19,7 @@ New in 2.0:
> hierarchy, a definition of the AM_PROG_VALAC macro found in file
> (say) '/usr/local/share/aclocal/my-vala.m4' should take precedence
> over the same-named automake-provided macro, as defined in file
> - '/usr/local/share/aclocal-1.14/vala.m4'.
> + '/usr/local/share/aclocal-2.0/vala.m4'.
>
> * Obsolescent features flagged:
>
> @@ -275,7 +275,7 @@ New in 1.13.3:
>
> * Documentation fixes:
>
> - - The documentation no longer mistakenly report that the obsolete
> + - The documentation no longer mistakenly reports that the obsolete
> 'AM_MKDIR_PROG_P' macro and '$(mkdir_p)' make variable are going
> to be removed in Automake 2.0.
>
> @@ -288,7 +288,7 @@ New in 1.13.3:
>
> - The test cases no longer have the executable bit set. This should
> make it clear that they are not meant to be run directly; as
> - explained in t/README, the can only be run through the custom
> + explained in t/README, they can only be run through the custom
> 'runtest' script, or by a "make check" invocation.
>
> - The testsuite has seen the introduction of a new helper function
> @@ -312,14 +312,14 @@ New in 1.13.2:
>
> - The long-deprecated but still supported two-arguments invocation form
> of AM_INIT_AUTOMAKE is documented once again. This seems the sanest
> - thing to do, given that support for such an usage might need to remain
> - in place for a unspecified amount of time in order to cater for people
> + thing to do, given that support for such usage might need to remain
> + in place for an unspecified amount of time in order to cater to people
> who want to define the version number for their package dynamically at
> configure runtime (unfortunately, Autoconf does not yet support this
> scenario, so we cannot delegate the work to it).
>
> - The serial testsuite harness is no longer reported as "deprecated",
> - but as "discouraged". We have no plan to remove it, not to make its
> + but as "discouraged". We have no plan to remove it, nor to make its
> use cause runtime warnings.
>
> - The parallel testsuite is no longer reported as "experimental"; it
>
> Sorry for not doing a better job of finding what branch each change
> belong to, and for not committing it myself...
>
No problem, I easily sorted out things myself. And fixed them with the
two attached patches. Thanks for the report!
> BTW, I also find your use of (sic!) strange, sic is normally used
> when you are quoting something that is obviously wrong, and you
> want to point out that it is indeed not a quoting mistake, but
> instead some error that was present also in the quoted source. But
> you are not even quoting anything, so the sic! mark makes no sense
> at all.
>
OK, fixed (see third attached patch).
>> or has some lingering failures on Windows, feel
>> free to speak up ASAP.
>
> Testsuite is (still) running, so far cxx-demo has failed with
> MSVC, and I guess it will fail for MinGW as well. From a cursory
> look it appear that the expected output is written with an MSYS
> bash and therefore has NL line endings, while the program output is
> for a windows program with CRNL line endings. diff then barfs.
>
Thanks for the analysis; shouldn't be too difficult to fix then, I
hope.
> distcheck-pr10470.sh also fails, apparently since ./test-driver
> isn't installed, here is a snippet from the log:
>
> + automake-1.99a --foreign -Werror -Wall
> parallel-tests: error: required file './test-driver' not found
> parallel-tests: 'automake --add-missing' can install 'test-driver'
>
Ah, this test is always skipped on POSIX systems, so I never got to update
it when the default was switched from serial-tests to parallel-tests.
> I will do better failure reports later when the testsuite
> has finished. BTW, this was from master, in hindsight I should have
> tried micro first, but I'll let this run finish.
>
Yes, I'm more interested to micro (since I plan to cut the 1.13.3 release
from it in a few days) and to maint (since I plan to cut the 1.14 release
from it in three weeks or so). But in the meantime, let's take a look at
the results on master.
Thanks,
Stefano
>From 54858251ad2db124038978c9ce59540d94f5ba91 Mon Sep 17 00:00:00 2001
Message-Id: <54858251ad2db124038978c9ce59540d94f5ba91.1369816131.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <stefano.lattar...@gmail.com>
Date: Wed, 29 May 2013 10:22:43 +0200
Subject: [PATCH] NEWS: fix Automake versions
Reported-by: Peter Rosin <p...@lysator.liu.se>
Signed-off-by: Stefano Lattarini <stefano.lattar...@gmail.com>
---
NEWS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 5172150..428a9a7 100644
--- a/NEWS
+++ b/NEWS
@@ -6,7 +6,7 @@ New in 2.0:
object will *always* be put into the subdirectory named after the source
file, rather than in the current directory. For instance, 'src/file.c'
and 'src/file.f90' will be compiled to 'src/file.o', and 'sub/dir/mu.cc'
- will be compiled to 'sub/dir/mu.o'. Put in another way, Automake 1.14
+ will be compiled to 'sub/dir/mu.o'. Put in another way, Automake 2.0
and later will *unconditionally* behave as older Automake versions did
when the 'subdir-objects' option was given.
@@ -19,7 +19,7 @@ New in 2.0:
hierarchy, a definition of the AM_PROG_VALAC macro found in file
(say) '/usr/local/share/aclocal/my-vala.m4' should take precedence
over the same-named automake-provided macro, as defined in file
- '/usr/local/share/aclocal-1.14/vala.m4'.
+ '/usr/local/share/aclocal-2.0/vala.m4'.
* Obsolescent features flagged:
--
1.8.3.rc3.8.g5e49f30
>From 030255252171248ff02da20b3f3f8c54b7bb31f9 Mon Sep 17 00:00:00 2001
Message-Id: <030255252171248ff02da20b3f3f8c54b7bb31f9.1369816120.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <stefano.lattar...@gmail.com>
Date: Wed, 29 May 2013 10:20:48 +0200
Subject: [PATCH] NEWS: fix typos and grammaros
Reported-by: Peter Rosin <p...@lysator.liu.se>
Signed-off-by: Stefano Lattarini <stefano.lattar...@gmail.com>
---
NEWS | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/NEWS b/NEWS
index ba396f7..39f5121 100644
--- a/NEWS
+++ b/NEWS
@@ -95,7 +95,7 @@ New in 1.13.3:
* Documentation fixes:
- - The documentation no longer mistakenly report that the obsolete
+ - The documentation no longer mistakenly reports that the obsolete
'AM_MKDIR_PROG_P' macro and '$(mkdir_p)' make variable are going
to be removed in Automake 2.0.
@@ -118,7 +118,7 @@ New in 1.13.3:
- The test cases no longer have the executable bit set. This should
make it clear that they are not meant to be run directly; as
- explained in t/README, the can only be run through the custom
+ explained in t/README, they can only be run through the custom
'runtest' script, or by a "make check" invocation.
- The testsuite has seen the introduction of a new helper function
@@ -153,14 +153,14 @@ New in 1.13.2:
- The long-deprecated but still supported two-arguments invocation form
of AM_INIT_AUTOMAKE is documented once again. This seems the sanest
- thing to do, given that support for such an usage might need to remain
- in place for a unspecified amount of time in order to cater for people
+ thing to do, given that support for such usage might need to remain
+ in place for an unspecified amount of time in order to cater to people
who want to define the version number for their package dynamically at
configure runtime (unfortunately, Autoconf does not yet support this
scenario, so we cannot delegate the work to it).
- The serial testsuite harness is no longer reported as "deprecated",
- but as "discouraged". We have no plan to remove it, not to make its
+ but as "discouraged". We have no plan to remove it, nor to make its
use cause runtime warnings.
- The parallel testsuite is no longer reported as "experimental"; it
--
1.8.3.rc3.8.g5e49f30
>From 080668642dcd66242fb5b29df39f4b0b164636c7 Mon Sep 17 00:00:00 2001
Message-Id: <080668642dcd66242fb5b29df39f4b0b164636c7.1369816338.git.stefano.lattar...@gmail.com>
In-Reply-To: <b1b1b2995f3ef29bc0bc60055668b3d17a2d4c88.1369816338.git.stefano.lattar...@gmail.com>
References: <b1b1b2995f3ef29bc0bc60055668b3d17a2d4c88.1369816338.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <stefano.lattar...@gmail.com>
Date: Wed, 29 May 2013 10:31:07 +0200
Subject: [PATCH 3/3] NEWS: drop an idiomatic use of latinism 'sic'
Reported-by: Peter Rosin <p...@lysator.liu.se>
Signed-off-by: Stefano Lattarini <stefano.lattar...@gmail.com>
---
NEWS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 428a9a7..c119856 100644
--- a/NEWS
+++ b/NEWS
@@ -190,8 +190,8 @@ New in 1.14:
2. It caches the check result in the 'am_cv_prog_cc_c_o'variable,
and not in a 'ac_cv_prog_cc_*_c_o' variable whose exact name
- in only dynamically computed at configure runtime (sic!) from
- the content of the '$CC' variable.
+ in only dynamically computed at configure runtime (really!)
+ from the content of the '$CC' variable.
3. It no longer automatically AC_DEFINE the C preprocessor
symbol 'NO_MINUS_C_MINUS_O'.
--
1.8.3.rc3.8.g5e49f30
