On 2013-01-12 11:05 +0100, Stefano Lattarini wrote: > On 01/11/2013 08:16 PM, Stefano Lattarini wrote: > > On 01/11/2013 07:19 PM, Eric Blake wrote: > >> On 01/10/2013 06:33 AM, Stefano Lattarini wrote: > >>> Reference: > >>> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13378#50> > >>> > >> > >>> @acindex AC_PROG_CC_C_O > >>> -This is like @code{AC_PROG_CC_C_O}, but it generates its results in > >>> -the manner required by Automake. You must use this instead of > >>> -@code{AC_PROG_CC_C_O} when you need this functionality, that is, when > >>> -using per-target flags or subdir-objects with C sources. > >>> +This is an @emph{obsolete wrapper} around @code{AC_PROG_CC_C_O}. New > >>> +code needs not to use this macro. It might be deprecated and > >> > >> s/needs not to/needs not/ > >> > > Fixed, thanks. I will soon merge the patch into maint. > > > Done. Also merged maint into master, and pushed.
Hm, so much for waiting a week to push... This all seems like needless complexity. It's unclear to me why my earlier suggestion (using AC_CONFIG_COMMANDS_PRE to expand AM_PROG_CC_C_O) was inadequate. This would also require no changes to autoconf, and we would not need to deprecate AM_PROG_CC_C_O, so no backwards compatibility hacks are required. These patches no longer apply to master, but here they are anyway. Nick Bowler (2): Use AC_DEFUN_ONCE to define AM_PROG_CC_C_O. Automatically call AM_PROG_CC_C_O as required. m4/init.m4 | 5 +++++ m4/minuso.m4 | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) -- 1.8.1
