Hi Karl, thanks for the patch. I have some nits however
On 01/03/2013 07:45 PM, Karl Berry wrote:
> Pursuant to http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13324 ...
>
> I suggest something like the following small change to the manual,
> mentioning dist-hook instead of just unconditionally saying "don't use
> directories in EXTRA_DIST". Even though dist-hook is described the next
> section, I for one read this text and never thought of going further :(.
>
Could you re-post this as a patch produced by "git format-patch"? That
would make it much easier for me to apply it. Also, a "semantic" nit,
below ...
> 2013-01-03 Karl Berry <k...@gnu.org>
>
> * automake.texi (Basics of Distribution): mention dist-hook
> as working around the problems of whole directories in EXTRA_DIST.
>
> --- /tmp/ORIG/automake.texi 2013-01-03 00:25:08.000000000 -0800
> +++ /tmp/automake.texi 2013-01-03 10:39:45.000000000 -0800
> @@ -8361,3 +8361,5 @@
> including, e.g., Subversion's @file{.svn} private directories or CVS/RCS
> -version control files. We recommend against using this feature.
> +version control files; thus we recommend against using this feature
> +as-is. However, you can use the @code{dist-hook} feature to ameliorate the
> +problem; see the next section.
>
... here, rather than have a generic "see next section", would be nice to
present the 'dist-hook' reference as an internal link (using @xref of @ref
I guess).
Thanks,
Stefano
