On 11/02/2012 10:50 AM, Stefano Lattarini wrote: > [+cc: automake-patches, bug-libtool] > [re-sending because delivery to automake and autoconf lists failed] > > References: > <http://lists.gnu.org/archive/html/autoconf-patches/2012-10/msg00007.html> > <http://lists.gnu.org/archive/html/autoconf-patches/2012-11/msg00000.html> > > On 11/01/2012 07:05 PM, Nick Bowler wrote: >> Hi Stefano, sorry for the delay. >> > Hi Nick, and thanks for the testing. > >> On 2012-10-31 11:03 +0100, Stefano Lattarini wrote: >>> On 10/23/2012 12:59 AM, Nick Bowler wrote: >>>> I am going to try all these patches to automake/autoconf/libtool soon; I >>>> will report back with the results! >>>> >>> Has anybody had a chance to try these patches? If not, does anyone >>> object to the idea of committing them anyway, and see how things work >>> out? It doesn't seem we're near to a release, so there's ample time >>> to revert these changes before cutting Autoconf 2.70, in case they >>> won't work as expected, or will reveal unforeseen issues. >> I got a chance to try these. I applied the patches on top of latest git >> autoconf and automake, as of today, and also checked out latest git >> libtool. >> >> I tried converting a package to use these, which originally had >> ACLOCAL_AMFLAGS = -I m4 -I common/m4. I removed the ACLOCAL_AMFLAGS >> from Makefile.am and added AC_CONFIG_MACRO_DIRS([m4 common/m4]) to >> configure.ac. Here are some initial observations: >> >> 1) Newlines can be used to separate items in AC_CONFIG_FILES, etc. >> However, aclocal explodes if you try to do this with >> AC_CONFIG_MACRO_DIRS: >> >> Use of uninitialized value $macro in exists at >> /tmp/autotools-test/bin/aclocal line 753, <GEN40> line 2. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 755, <GEN40> line 2. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 755, <GEN40> line 2. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 755, <GEN40> line 2. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 760, <GEN40> line 2. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 764, <GEN40> line 2. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 768, <GEN40> line 2. >> Use of uninitialized value $macro in exists at >> /tmp/autotools-test/bin/aclocal line 753, <GEN82> line 3. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 755, <GEN82> line 3. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 755, <GEN82> line 3. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 755, <GEN82> line 3. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 760, <GEN82> line 3. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 764, <GEN82> line 3. >> Use of uninitialized value $macro in string eq at >> /tmp/autotools-test/bin/aclocal line 768, <GEN82> line 3. >> >> This strikes me as extremely odd because the output >> of autoconf --trace AC_CONFIG_MACRO_DIRS is the same >> in either case. >> > I can reproduce the problem. The patch below enhances the automake > testsuite in order to catch it. I hope I'll be able to come up with > a fix soon enough. > And here is an updated patch series introducing AC_CONFIG_MACRO_DIRS support that also takes care of this issue. Any further testing would be appreciated.
-*-*-*- Stefano Lattarini (4): aclocal: multiple local m4 macro dirs with AC_CONFIG_MACRO_DIRS aclocal: diagnose non-existing directories in AC_CONFIG_MACRO_DIRS better tests: better coverage for AC_CONFIG_MACRO_DIRS aclocal: smash newlines in arguments of traced macros aclocal.in | 73 +++++----- t/aclocal-macrodir.tap | 23 +++- t/aclocal-macrodirs.tap | 344 ++++++++++++++++++++++++++++++++++++++++++++++++ t/list-of-tests.mk | 2 + t/subpkg-macrodir.sh | 93 +++++++++++++ 5 files changed, 497 insertions(+), 38 deletions(-) create mode 100755 t/aclocal-macrodirs.tap create mode 100755 t/subpkg-macrodir.sh -- 1.8.0
