Hi Jim, thanks for the patch. On 09/12/2012 05:53 PM, Jim Meyering wrote: > > * t/gettext-macros.sh: Fix typo in name of macro emitted into > mk-dirp.m4: s/AM_MKDIR_P/AM_PROG_MKDIR_P/ > Yikes, how have I been missing that ?!?
Maybe, to help me (and future readers) to understand how this blunder can have survived so long, you could elaborate, in the commit message, about how you've been bitten by it, or how you've come across it ... > --- > t/gettext-macros.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/gettext-macros.sh b/t/gettext-macros.sh > index 1d94dad..f548d1a 100755 > --- a/t/gettext-macros.sh > +++ b/t/gettext-macros.sh > @@ -80,7 +80,7 @@ echo "export ACLOCAL_PATH" >> get.sh > > # Even recent versions of gettext used the now-obsolete 'AM_PROG_MKDIR_P' > # m4 macro. So we need the following to avoid spurious errors. > -echo 'AC_DEFUN([AM_MKDIR_P], [AC_MKDIR_P([$@])])' >> m4/mk-dirp.m4 > +echo 'AC_DEFUN([AM_PROG_MKDIR_P], [AS_MKDIR_P([$@])])' >> m4/mk-dirp.m4 > I believe you should also do the change 's/AS_MKDIR_P/AC_PROG_MKDIR_P/'. ACK with those nits addressed. Thanks, Stefano
