On 06/20/2012 06:45 PM, Eric Blake wrote: > On 06/20/2012 10:39 AM, Stefano Lattarini wrote: >> This fixes several weaknesses and buglets in the 'bootstrap' convenience >> target offered in GNUmakefile (and its supporting code). Refer to the >> extensive code comments in there for more details. >> >> * GNUmakefile: Almost completely rewritten. > > How much, if any, of this should be merged into gnulib's GNUmakefile as > part of the 'maintainer-makefile' module? > Very little I fear; Automake doesn't use Gnulib, its bootstrap.sh script is quite different from Gnulib's bootstrap script, and Automake cannot use version numbers based on output of 'git-version-gen' (I tried, but that busted up support for specifying minimal version numbers in AM_INIT_AUTOMAKE and AUTOMAKE_OPTIONS).
> >> -else >> - include ./Makefile >> - include $(srcdir)/syntax-checks.mk >> + # Any target but 'bootstrap' specified in an unconfigured tree >> + # is an error, env when the user is running GNU make. > > did you mean 'even' instead of 'env'? > > Other than that, I didn't review closely, but assume it is decent. > Well, at least I can say I've verified it to work correctly in all the cases I care about ;-) Regards, Stefano
