close 10866 thanks On 03/14/2012 10:06 PM, Eric Blake wrote: > On 03/14/2012 03:02 PM, P. Martin wrote: >> On Mar 14, 2012, Stefano Lattarini <stefano.lattar...@gmail.com> wrote: >>> >>>> FAIL: cond41.test >>> ... >>> Weird and annoying, the line reported in the error message is off by one ... >>> I wouldn't loose my sleep on this, but it would be nice to understand the >>> reason of this racy failure; so I'm keeping the bug report open. >> >> >> Ok good info on the texinfo makeinfo is old infoz. >> I just got finished testing 1.11a on a clean Lion install >> with XCode-4.3.1. and the same deps as before: >> I still get that FAIL: cond41.test. Is it the old m4? >> >> m4-1.4.6 > > Yes - old m4 did error reporting at the end of an error construct rather > than the beginning, which could very easily explain the off-by-one. > Thanks to both for the diagnosis. I can indeed reproduce the problem in automake master using GNU m4 1.4.6. I've thus applied the attached patch, that fixes the issue, and I'm finally closing this bug report (yay!)
Thanks for all the patience and help, Stefano
>From 28ed42d905141d2ab4f8431b0599c906fe7c6408 Mon Sep 17 00:00:00 2001 Message-Id: <28ed42d905141d2ab4f8431b0599c906fe7c6408.1331760188.git.stefano.lattar...@gmail.com> From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Wed, 14 Mar 2012 22:22:40 +0100 Subject: [PATCH] tests: fix spurious failure with older m4 Reported by Panther Martin in automake bug#10866, diagnosed by Panther Martin and Eric Blake. Older GNU m4 versions (e.g., 1.4.6) did error reporting at the end of an error construct rather than the beginning. This was causing a spurious testsuite failure due to an off-by-one error in the line number reported in an aclocal diagnostic. * tests/cond41.test: Keep all the body of the 'AM_COND_IF' invocation on a single line, to avoid the off-by-one error. Signed-off-by: Stefano Lattarini <stefano.lattar...@gmail.com> --- tests/cond41.test | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tests/cond41.test b/tests/cond41.test index ee17a95..7c59a0a 100755 --- a/tests/cond41.test +++ b/tests/cond41.test @@ -19,8 +19,7 @@ . ./defs || Exit 1 cat >>configure.ac <<'END' -AM_COND_IF([BAD_COND], - [AC_CONFIG_FILES([file1])]) +AM_COND_IF([BAD_COND], [AC_CONFIG_FILES([file1])]) AC_OUTPUT END -- 1.7.9
