Hi Dave, Jeff. Thanks for the patch! On 02/25/2012 03:22 AM, Dave Goodell wrote: > Portland Group C Compiler support based on a code from Jeff Daily @ PNNL > via the automake list and automake bug #8880: > By a very cursory look, this patch seems safe and unobtrusive (it shouldn't influence the existing depmodes at all, so basically no room for regression). So I'd love to apply the patch before the next Automake release (1.12).
I also assume you've re-run the whole automake testsuite after applying this patch (to master), *using the Portland C compilers*, and seen no failure, right? If you haven't, here is how you can do that (from a *clean* automake checkout with your patch applied): $ ./bootstrap $ export CC=pgcc CXX=pgCC FC=pgf90 F77=pgf77 $ ./configure $ make -jN check That said, let's come to the dreaded legal aspects... Since the change you are proposing does not qualify as "tiny" or "trivial" in the sense of the GNU Coding Standards -- reference: <http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant> we'll need a proper disclaimer from *all* the people who have written this code before incorporating it in the automake repository. So I ask: Would you and the other people that have written this code be willing to assign the copyright to the Free Software Foundation, so that we could install it in package? or, this is not possible or undesired for some reason, Would you and the other people that have written this code be willing to sign a copyright disclaimer to put this change in the public domain, so that we can install it in package? Thanks, Stefano
