severity 10737 minor
tags 10737 patch
close 10737
thanks

Hi Larry, thanks for the report.  And sorry for the late answer,
but your message has reached the mailing list just today :-/

On 01/31/2012 04:30 AM, Larry Daniel wrote:
> 
>
> =============================================
>   GNU Automake 1.11: tests/test-suite.log
> =============================================

Consider that 1.11 is already some years old, and, most importantly,
suffers from a know security vulnerability:

  <http://thread.gmane.org/gmane.comp.sysutils.autotools.announce/131>

I'd advise you to install the latest version 1.11.3 instead.

> 1 of 628 tests failed.  (101 tests were not run).
>
> FAIL: aclocal5.test (exit: 1)
>
[SNIP]

Ah-ah, you've hit this known and extremely low-probability bug:

 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8365>

Attached is a testsuite enhancement to avoid similar failures in
the future.

Thanks again,
  Stefano
>From f5f838a2eba1bb26a755762665095ae76fe59a9e Mon Sep 17 00:00:00 2001
Message-Id: <f5f838a2eba1bb26a755762665095ae76fe59a9e.1328640835.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <stefano.lattar...@gmail.com>
Date: Tue, 7 Feb 2012 19:53:49 +0100
Subject: [PATCH] tests: fix a timestamp-related spurious failures

Fixes automake bug#10737.  Report from Larry Daniel.
See also automake bug#8365 and commit 'v1.11-329-gd4df619' of
30-03-2011, "tests: fix timestamp-related failures".

* tests/aclocal5.test: Sleep before modifying m4 files that should
trigger remake rules.  This fixes an hard-to-hit timestamp-related
race condition.
* THANKS: Update.
---
 THANKS              |    1 +
 tests/aclocal5.test |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/THANKS b/THANKS
index e6730b4..b512b6b 100644
--- a/THANKS
+++ b/THANKS
@@ -194,6 +194,7 @@ Klaus Reichl		klaus.rei...@alcatel.at
 Krzysztof Żelechowski	giecr...@stegny.2a.pl
 L. Peter Deutsch	gh...@aladdin.com
 Ladislav Strojil	ladislav.stro...@seznam.cz
+Larry Daniel		la...@larrybrucedaniel.com
 Larry Jones		larry.jo...@sdrc.com
 Lars Hecking		lheck...@nmrc.ucc.ie
 Lars J. Aas		la...@sim.no
diff --git a/tests/aclocal5.test b/tests/aclocal5.test
index b206587..ec032e4 100755
--- a/tests/aclocal5.test
+++ b/tests/aclocal5.test
@@ -51,6 +51,7 @@ $MAKE
 # updated, even from a sub-directory.  Check that AU_ALIAS is
 # recognized. Change the definition of AM_TEST to check that its new
 # definition is used.
+$sleep # Modified configure dependencies must be newer than config.status.
 echo 'AU_ALIAS([AM_TEST], [AC_SUBST])' > m4/moredefs.m4
 cd sub
 $MAKE
@@ -64,6 +65,7 @@ test -f $me-1.0/m4/moredefs.m4
 
 # Change the definition of AM_TEST to check that its new definition is
 # used.  Check that AC_DEFUN_ONCE is caught.
+$sleep # Modified configure dependencies must be newer than config.status.
 echo 'AC_DEFUN_ONCE([AM_TEST], [AC_SUBST(__$1__)])' > m4/moredefs.m4
 $MAKE
 grep 'm4/moredefs\.m4' aclocal.m4
-- 
1.7.7.3

Reply via email to