Stefano Lattarini skrev 2012-02-02 20:33: > On 02/02/2012 08:16 PM, Peter Rosin wrote: >> Hi! >> > Hi Peter. > >> When I run the testsuite with CC="cl -nologo" in the environment, >> make -e in check8.test clobbers the rewritten CC (AM_PROG_CC_C_O >> rewrites CC, remember?) causing the test to fail. >> >> I have two alternativ patches for this, one that makes the test >> skip in this situation and one that makes it pass. I don't know >> which you consider best, so I have included both version... >> > Actually, there is a much simpler approach: since 'AM_COLOR_TESTS' > is *not* set in the automake-generated Makefiles, it is possible to > override it from the environment *without* using the '-e' option > of make. So, to solve your problem (and at the same time make the > test unconditionally more robust) just drop the '-e' from the make > call :-) > > Will you take care of reworking the patch, or should I do it?
I'll do it, that was one other approach I considered, but I didn't know the rules and chickened out... Cheers, Peter
