Hi Bruno, sorry for the delay. On 01/04/2012 03:44 PM, Bruno Haible wrote: > Hi Stefano, > >>> Here's a proposed patch for automake. >>> >> Thanks. I have some minor nits and qualms with the patch, which I hope >> you can address in a re-roll. > > Was this meant as an explanation to your fellow Automake maintainers, > or to me personally? > It is an explanation for all the potential contributors; it is not meant *exclusively* for you. Sorry for not being more clear.
Anyway, it's perfectly OK not to address most the nits I've reported, as I can address them myself more easily and faster, as you have correctly pointed out (and as I *should* have pointed out myself, instead of leaving it implicit; sorry about that). There is one exception though, and this is for you personally ... > > [SNIP various good points] > >> First (and this is the only serious objection): could you please >> re-send your patch formatting with "git format-patch"? That will make >> it far more easy to apply. > > Patches that are sent without git specific formatting can be applied > with "patch -p0 < mailfile" or "patch -p1 < mailfile". > True, and in fact that worked with your patch as well. *But*, since you are using git anyway, and are likely quite proficient with it, why not use the "blessed", standard way to prepare patches, that is, "git format-patch"? Regards, Stefano
