On 12/22/2011 03:58 PM, Stefano Lattarini wrote: > > On 12/22/2011 03:41 PM, Eric Blake wrote: >> >> On 12/22/2011 07:30 AM, Stefano Lattarini wrote: >>> >>> +# Dummy test case, aimed at reporting useful system information in the >>> +# final `test-suite.log'. This way, if a user experiencing a failure in >>> +# the Automake test suite only sends us the `test-suite.log' file upon, >>> +# we won't have to ask him for more information to start analyzing the >>> +# failure (that had happened too many times in the past!). >> >> grammar: >> >> This way, if a user experiences a failure in the Automake test suite, >> then only sends us the `test-suite.log', we won't have to... >> > Will fix in a follow-up (probably this evening). > Done with the attached patch.
>>> + >>> +if test $st -eq 0; then >>> + # This test SKIPs, so that all the information is has gathered and >> >> s/is has // >> > Ditto. > Here I preferred to do s/is has/it has/; hope it's OK as well (it seems to me). Thanks, Stefano
>From a95d9dc4f4dbac2c9a34615078cb78d16e0c7805 Mon Sep 17 00:00:00 2001 Message-Id: <a95d9dc4f4dbac2c9a34615078cb78d16e0c7805.1324574266.git.stefano.lattar...@gmail.com> From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Thu, 22 Dec 2011 18:17:26 +0100 Subject: [PATCH] fix: typos and grammaros in comments of the new test * tests/get-sysconf.test: Fix few typos, grammaros and botched wording. Reported by Eric Blake. --- ChangeLog | 6 ++++++ tests/get-sysconf.test | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index de95269..a24ee36 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2011-12-22 Stefano Lattarini <stefano.lattar...@gmail.com> + fix: typos and grammaros in comments of the new test + * tests/get-sysconf.test: Fix few typos, grammaros and botched + wording. Reported by Eric Blake. + +2011-12-22 Stefano Lattarini <stefano.lattar...@gmail.com> + tests: report useful system information in 'test-suite.log' It has already happened various times that a user has run the automake testsuite, experienced a failure, read the messages diff --git a/tests/get-sysconf.test b/tests/get-sysconf.test index 32d1038..1a549a3 100755 --- a/tests/get-sysconf.test +++ b/tests/get-sysconf.test @@ -15,8 +15,8 @@ # along with this program. If not, see <http://www.gnu.org/licenses/>. # Dummy test case, aimed at reporting useful system information in the -# final `test-suite.log'. This way, if a user experiencing a failure in -# the Automake test suite only sends us the `test-suite.log' file upon, +# final `test-suite.log'. This way, if a user experiences a failure in +# the Automake test suite and then only sends us the `test-suite.log', # we won't have to ask him for more information to start analyzing the # failure (that had happened too many times in the past!). @@ -37,7 +37,7 @@ cat "$testbuilddir/aclocal-$APIVERSION" || st=1 cat "$testbuilddir/automake-$APIVERSION" || st=1 if test $st -eq 0; then - # This test SKIPs, so that all the information is has gathered and + # This test SKIPs, so that all the information it has gathered and # printed will get unconditionally copied into the `test-suite.log' # file. Exit 77 -- 1.7.7.3
