Stefano Lattarini skrev 2011-11-26 19:11: > On Saturday 26 November 2011, Stefano Lattarini wrote: >> >> Attached are the two patches I had promised. I'll wait 72 hours or your >> ACK (whichever comes first) before pushing. >> >> Regards, >> Stefano >> > Hmm... on a second thought, the check in txinfo21.test that sets > `$have_correct_dir_timestamp' makes little sense -- it fails also > on Linux, and *that's correct* in fact, because it's normal that > a directory timestamp is not updated when a pre-existing file in > it is touched! The timestamp should be updated if a new file is > created in the directory, or if the directory is removed and > re-created. > > I propose to substitute the first patch with the attached one > instead. Peter, if you have time, could you test if it works > correctly on Cygwin?
Oh crap, crap crap. It looks like I've been bitten by this: http://cygwin.com/ml/cygwin/2011-03/msg00836.html Please drop the patch for txinfo21 and sorry for the noise. Regarding the commit message for the 2/2 patch, the trouble with the double leading slash is not Cygwin specific, but instead a run-of-the-mill POSIX violation. A leading double slash is the key into an implementation defined namespace. >From the end of section 4.11 at: http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap04.html#tag_04_11 "A pathname that begins with two successive slashes may be interpreted in an implementation-defined manner, although more than two leading slashes shall be treated as a single slash." So, please use this commit message (or something like it) tests: fix 'distcheck-override-infodir.test' on Cygwin * tests/distcheck-override-infodir.test (Makefile.am): Do not add any `/' between $(DESTDIR) and the following paths. Otherwise, when $(DESTDIR) is empty, the recipes will try to access files with a leading double slash, which have an implementation defined interpretation. For Cygwin they mean UNC paths. Cheers, Peter
