* tests/gen-testsuite-part: Avoid putting too much "FIXME"
comments in the generated test scripts, since they end up
being just counter-productive noise when one has to grep
the test scripts looking for real "FIXME" items.
---
ChangeLog | 8 ++++++++
tests/gen-testsuite-part | 5 ++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 04f3372..46f09c4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
2011-11-05 Stefano Lattarini <stefano.lattar...@gmail.com>
+ generated tests: avoid extra "FIXME" comments
+ * tests/gen-testsuite-part: Avoid putting too much "FIXME"
+ comments in the generated test scripts, since they end up
+ being just counter-productive noise when one has to grep
+ the test scripts looking for real "FIXME" items.
+
+2011-11-05 Stefano Lattarini <stefano.lattar...@gmail.com>
+
Merge branch 'master' into testsuite-work
* tests/extra-portability.test: Use `$am_original_AUTOMAKE'
instead of the obsolete `$original_AUTOMAKE'.
diff --git a/tests/gen-testsuite-part b/tests/gen-testsuite-part
index c547f4a..6009dbc 100755
--- a/tests/gen-testsuite-part
+++ b/tests/gen-testsuite-part
@@ -84,10 +84,11 @@ sub line_match ($$)
sub write_wrapper_script ($$$)
{
my ($file_handle, $wrapped_test, $shell_setup_code, $creator_name) = @_;
+ # FIXME: we use some creative quoting in the generated scripts,
+ # FIXME: to please maintainer-check.
print $file_handle unindent <<EOF;
#! /bin/sh
# This file has been automatically generated. DO NOT EDIT BY HAND!
- # FIXME: creative quoting to please maintainer-check.
. ./defs-static || exit '99';
$shell_setup_code
# In the spirit of VPATH, we prefer a test in the build tree
@@ -95,12 +96,10 @@ sub write_wrapper_script ($$$)
for dir in . "\$testsrcdir"; do
if test -f "\$dir/$wrapped_test"; then
echo "\$0: will source \$dir/$wrapped_test"
- # FIXME: creative quoting to please maintainer-check.
. "\$dir/$wrapped_test"; exit "\$?"
fi
done
echo "\$0: cannot find wrapped test \\`$wrapped_test'" >&2
- # FIXME: creative quoting to please maintainer-check.
exit '99'
EOF
}
--
1.7.2.3
