Hi Peter, thanks for the patch.
On Wednesday 19 October 2011, Peter Rosin wrote:
> From 1b554ab39084ecaf767fbea031763c211bc72e4e Mon Sep 17 00:00:00 2001
> From: Peter Rosin <p...@lysator.liu.se>
> Date: Wed, 19 Oct 2011 23:18:49 +0200
> Subject: [PATCH 2/2] Invent new extra-portability warning category for
> AM_PROG_AR.
>
Micro-nit: we've started to write all the git commit summaries according
to the format "<topic>: <message>" (no trailing full space); so what about
rewriting the summary as follows?
warnings: new 'extra-portability' category, for AM_PROG_AR
> * lib/Automake/ChannelDefs.pm: Register new extra-portability
> warning channel.
> (switch_warning): Turn off extra-portability if portability is
> turned off, and turn on portability if extra-portability is
> turned on.
> (set_strictness): Silence extra-portability for --gnits, --gnu
> and --foreign.
>
Could you please add a test case checking these behaviours? Thanks.
> [SNIP]
>
> diff --git a/doc/automake.texi b/doc/automake.texi
> index 5d0942d..b238abf 100644
> --- a/doc/automake.texi
> +++ b/doc/automake.texi
> @@ -2680,6 +2680,8 @@ user redefinitions of Automake rules or variables
> @item portability
> portability issues (e.g., use of @command{make} features that are
> known to be not portable)
> +@item extra-portability
> +extra portability issues related to obscure tools
>
IMHO, listing `Microsoft lib archiver' among these "obscure tools"
would really help the reader in getting a better understanding of
the term.
> @item syntax
> weird syntax, unused variables, typos
> @item unsupported
> @@ -2702,6 +2704,11 @@ are enabled in @option{--gnu} and @option{--gnits}
> strictness.
> On the other hand, the @option{silent-rules} options (@pxref{Options})
> turns off portability warnings about recursive variable expansions.
>
> +Turning off @samp{portability} will also turn off @samp{extra-portability},
> +and similarly turning on @samp{extra-portability} will also turn on
> +@samp{portability}. However, turning on @samp{portability} or turning
> +off @samp{extra-portability} will not affect the other category.
> +
Could you please add a test case checking these behaviours, and reference
it in a suitable comment? Thanks.
ACK from me for the rest of the patch.
Thanks,
Stefano
