Hi Peter, thanks for the review.
On Sunday 29 May 2011, Peter Rosin wrote:
> Den 2011-05-29 16:26 skrev Stefano Lattarini:
> > Currently, every decent non-GNU make program makes it possible
> > to remake out-of-date autotools-generated files with a simple
> > "make Makefile" issued from the top-level directory. And while
> > having to run "make Makefile" by hand isn't as convenient as
> > the GNU make feature of "automatic remake *and reloading* of
> > out-of-date makefiles", it is usually good enough and definitely
> > worth having.
> >
> > Unfortunately, a silly limitation in the current implementation
> > of remake rules prevents this idiom from working when it's used
> > outside the top-level directory. Luckily, this limitation is
> > easy to remove, and that's what this patch does.
>
> Nitpick: The tense is wrong for a ChangeLog entry, and there's a tab
> in there as well. Suggestion:
>
> Remove silly limitation that prevents this idiom from
> working outside the top-level directory.
>
> I'm not sure if the essay style of the first paragraph should stay
> or go though?
>
I mostly agree with your objections. What do you think about this
ChangeLog entry instead?
remake: behave better with non-GNU make in subdirectories
Currently, with every decent make program, it is possible to
rebuild out-of-date autotools-generated files with a simple
"make Makefile" -- but for this to work reliably with non-GNU
make implementations, the command must be issued from the
top-level directory. This patch removes such limitation.
* lib/am/configure.am (am--refresh): Depend on `%MAKEFILE%'.
* tests/defs.in (using_gmake): New function, backported from the
`master' branch (and simplified).
* tests/remake-subdir.test: New test.
* tests/remake-subdir2.test: Likewise.
* tests/remake-subdir-gnu.test: Likewise.
* tests/remake-subdir-from-subdir.test: Likewise.
* tests/Makefile.am (TESTS): Update.
Thanks,
Stefano
