Hello automakers. Clening up and oldish blunder of mine ...
-*-*-
maintainer check: quote literal `$' in Makefile rule
* Makefile.am (sc_tests_PATH_SEPARATOR): Escape literal `$'
character in double-quoted string. Fix a bug in which the rule
emitted an erroneously empty substring in its error message.
---
ChangeLog | 7 +++++++
Makefile.am | 2 +-
Makefile.in | 2 +-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 6855f9a..0ef2910 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-04-14 Stefano Lattarini <stefano.lattar...@gmail.com>
+
+ maintainer check: quote literal `$' in Makefile rule
+ * Makefile.am (sc_tests_PATH_SEPARATOR): Escape literal `$'
+ character in double-quoted string. Fix a bug in which the rule
+ emitted an erroneously empty substring in its error message.
+
2010-09-25 Stefano Lattarini <stefano.lattar...@gmail.com>
Testsuite: Use `$PATH_SEPARATOR', not `:', when extending PATH.
diff --git a/Makefile.am b/Makefile.am
index d19d974..de0bb73 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -413,7 +413,7 @@ sc_tests_plain_egrep_fgrep:
## Using `:' as a PATH separator is not portable.
sc_tests_PATH_SEPARATOR:
@if grep -E '\bPATH=.*:.*' $(srcdir)/tests/*.test ; then \
- echo "Use \`$$PATH_SEPARATOR', not \`:', in PATH definitions above."
1>&2; \
+ echo "Use \`\$$PATH_SEPARATOR', not \`:', in PATH definitions above."
1>&2; \
exit 1; \
fi
diff --git a/Makefile.in b/Makefile.in
index 649565b..c9a5bd9 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -1093,7 +1093,7 @@ sc_tests_plain_egrep_fgrep:
sc_tests_PATH_SEPARATOR:
@if grep -E '\bPATH=.*:.*' $(srcdir)/tests/*.test ; then \
- echo "Use \`$$PATH_SEPARATOR', not \`:', in PATH definitions above."
1>&2; \
+ echo "Use \`\$$PATH_SEPARATOR', not \`:', in PATH definitions above."
1>&2; \
exit 1; \
fi
--
1.7.2.3
-*-*-
I've applied this patch to a temporary bug-fixing branch, merged
this branch into maint, merged maint into master, and pushed.
Regards,
Stefano
