Hello Ralf.
On Thursday 20 January 2011, Ralf Wildenhues wrote:
> * Ralf Wildenhues wrote on Wed, Jan 19, 2011 at 07:56:20PM CET:
> > * Stefano Lattarini wrote on Tue, Jan 18, 2011 at 11:57:24PM CET:
> > > On Tuesday 18 January 2011, Ralf Wildenhues wrote:
> > > > This patch fixes all but 9 of the 76 or so instspc*.test failures on
> > > > Tru64. It is for the tests-init branch, or a tests-init-fixes on top of
> > > > v1.11-395-ge118126 I guess. I'll wait a couple of days before pushing.
> > > >
> > > The patch is ok with me (but see below). BTW, the idea of having an
> > > 'errexit' clean `tests/defs' sounds good to me, indipendently from the
> > > issue at hand. But I won't go as far as asking for a separate patch ;-)
>
> Ahh, but it would have needed to be in that very patch, unfortunately.
> As it is, my last patch fixed Tru64, but regressed NetBSD by roughly the
> same number of failures, because `unset NOT_SET' fails there.
>
And with older Bash versions also, BTW:
$ bash-2.0 -c 'echo $BASH_VERSION; unset NOT_SET'; echo $?
2.00.0(1)-release
1
$ bash-2.05 -c 'echo $BASH_VERSION; unset NOT_SET'; echo $?
2.05.0(1)-release
1
$ # but luckily ...
$ bash-3.0 -c 'echo $BASH_VERSION; unset NOT_SET'; echo $?
3.00.0(1)-release
0
> Luckily the `set +e/set -e' commands weren't actually required for
> Tru64 sh to work (they just didn't help either, that was all), so
> unless you complain I'll reinstate that part of the code again.
>
How could I complain about fixing a regression? ;-)
Also, making tests/defs `set -e' clean is quite low-priority. I
might attempt a patch anyway, but than I cannot test it properly :-(
Oh well, some other time perhaps ...
> For tests-init -> master.
>
> Thanks,
> Ralf
>
> tests: revert not turning off errexit in instspc-test.sh
>
> * tests/instspc-tests.sh: Turn off errexit while sourcing defs,
> the scripts might still not be clean.
>
> diff --git a/tests/instspc-tests.sh b/tests/instspc-tests.sh
> index 78f40c4..38a63a4 100755
> --- a/tests/instspc-tests.sh
> +++ b/tests/instspc-tests.sh
> @@ -191,8 +191,12 @@ fi
>
> ### If we are still here, we have to run a test ...
>
> -# We'll need the full setup provided by `tests/defs'.
> +# We'll need the full setup provided by `tests/defs'. Temporarly disable
> +# the errexit flag, since the setup code might not be prepared to deal
> +# with it.
> +set +e
> . ./defs || Exit 99
> +set -e
>
> eval "instspc_test_string=\${instspc__$instspc_test_name}" || Exit 99
> if test x"$instspc_test_string" = x; then
>
Thanks,
Stefano
