This tiny patch fix a nasty bug in 'silent5.test' (due to the use of grep instead of egrep) that could have lead to false negatives.
The bug was introduced in one of my previous patches ("Improved test silent5.test", de09b369b135b971bffb0efe383716237b9bf7f1). In hindsight, a somewhat ironic summary message... Regards, Stefano
From 6b78b3469c2f01e9a2a0746c2764a2eed96beb6f Mon Sep 17 00:00:00 2001 From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Wed, 23 Jun 2010 21:56:04 +0200 Subject: [PATCH] Fix bugs in test script silent5.test. * tests/silent5.test: Fixed a nasty bug (due to the use of grep instead of egrep) that could have lead to false negatives. --- ChangeLog | 6 ++++++ tests/silent5.test | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 469578c..5ae49de 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2010-06-23 Stefano Lattarini <stefano.lattar...@gmail.com> + + Fix bugs in test script silent5.test. + * tests/silent5.test: Fixed a nasty bug (due to the use of grep + instead of egrep) that could have lead to false negatives. + 2010-06-21 Ralf Wildenhues <ralf.wildenh...@gmx.de> Fix minor testsuite issues, update docs, for Yacc/Lex changes. diff --git a/tests/silent5.test b/tests/silent5.test index e1134e8..4a9c4c1 100755 --- a/tests/silent5.test +++ b/tests/silent5.test @@ -80,11 +80,11 @@ do_and_check_verbose_build () grep ' -c ' stdout grep ' -o ' stdout - grep '(CC|CXX|FC|F77|LD) ' stdout && Exit 1 + $GREP '(CC|CXX|FC|F77|LD) ' stdout && Exit 1 if $rebuild; then :; else grep 'ylwrap ' stdout - grep '(LEX|YACC) ' stdout && Exit 1 + $EGREP '(LEX|YACC) ' stdout && Exit 1 fi unset rebuild -- 1.6.5