And here are the last two patches which should complete the first step of making the Automake testsuite more easy to run with different compilers.
Regards, Stefano -*-*-*- Make sure all tests needing a C compiler require it explicitly. The list of the test scripts which needed a C compiler but failed to require it explicitly was found by running (in the `tests/' directory): $ CC=no make check -j24 and seeing which tests reported FAIL instead of SKIP. After the present change, all those previously failing tests correctly report SKIP. * tests/aclocal4.test ($required): Add `cc'. * tests/ansi.test: Likewise. ... * tests/yacc7.test: Likewise. * tests/yflags.test: Likewise. ... 61 files changed, 176 insertions(+), 59 deletions(-) -*-*-*- Fixup requirements introduced by previous change. * tests/libtoo10.test: Require `gcc', not `cc', as the test might fail with some non-GNU C compilers. * tests/ltorder.test: Likewise. --- ChangeLog | 7 +++++++ tests/libtoo10.test | 3 ++- tests/ltorder.test | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) -*-*-*-
From b093828db38ab11d86e75c3798ef4054a986965a Mon Sep 17 00:00:00 2001 From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Wed, 23 Jun 2010 08:47:38 +0200 Subject: [PATCH 3/4] Make sure all tests needing C compiler require it explicitly. The list of the test scripts which needed a C compiler but failed to require it explicitly was found by running (in the `tests/' directory): $ CC=no make check -j24 and seeing which tests reported FAIL instead of SKIP. After the present change, all those previously failing tests correctly report SKIP. * tests/aclocal4.test ($required): Add `cc'. * tests/ansi.test: Likewise. * tests/check5.test: Likewise. * tests/check6.test: Likewise. * tests/check7.test: Likewise. * tests/check8.test: Likewise. * tests/check9.test: Likewise. * tests/cond11.test: Likewise. * tests/cond21.test: Likewise. * tests/cond22.test: Likewise. * tests/cond30.test: Likewise. * tests/cond31.test: Likewise. * tests/cond32.test: Likewise. * tests/cond34.test: Likewise. * tests/cond39.test: Likewise. * tests/cond5.test: Likewise. * tests/condd.test: Likewise. * tests/depcomp6.test: Likewise. * tests/depcomp7.test: Likewise. * tests/depend5.test: Likewise. * tests/distcleancheck.test: Likewise. * tests/distname.test: Likewise. * tests/exeext.test: Likewise. * tests/exeext4.test: Likewise. * tests/instdir-ltlib.test: Likewise. * tests/instdir-prog.test: Likewise. * tests/instfail-libtool.test: Likewise. * tests/instfail.test: Likewise. * tests/lflags.test: Likewise. * tests/libtoo10.test: Likewise. * tests/libtoo11.test: Likewise. * tests/ltorder.test: Likewise. * tests/nostdinc.test: Likewise. * tests/parallel-tests4.test: Likewise. * tests/parallel-tests5.test: Likewise. * tests/parallel-tests7.test: Likewise. * tests/pr287.test: Likewise. * tests/regex.test: Likewise. * tests/silent.test: Likewise. * tests/silent3.test: Likewise. * tests/silent5.test: Likewise. * tests/silent9.test: Likewise. * tests/silentlex.test: Likewise. * tests/silentyacc.test: Likewise. * tests/specflg10.test: Likewise. * tests/stdinc.test: Likewise. * tests/strip.test: Likewise. * tests/subdirbuiltsources.test: Likewise. * tests/subobj5.test: Likewise. * tests/subst2.test: Likewise. * tests/suffix10.test: Likewise. * tests/suffix11.test: Likewise. * tests/suffix12.test: Likewise. * tests/suffix13.test: Likewise. * tests/transform2.test: Likewise. * tests/upc.test: Likewise. * tests/upc3.test: Likewise. * tests/vala4.test: Likewise. * tests/yacc7.test: Likewise. * tests/yflags.test: Likewise. --- ChangeLog | 71 +++++++++++++++++++++++++++++++++++++++++ tests/aclocal4.test | 4 +- tests/ansi.test | 1 + tests/check5.test | 1 + tests/check6.test | 3 +- tests/check7.test | 3 +- tests/check8.test | 1 + tests/check9.test | 1 + tests/cond11.test | 3 +- tests/cond21.test | 3 +- tests/cond22.test | 3 +- tests/cond30.test | 5 ++- tests/cond31.test | 5 ++- tests/cond32.test | 5 ++- tests/cond34.test | 5 ++- tests/cond39.test | 3 +- tests/cond5.test | 4 ++- tests/condd.test | 3 +- tests/depcomp6.test | 3 +- tests/depcomp7.test | 4 +- tests/depend5.test | 3 +- tests/distcleancheck.test | 3 +- tests/distname.test | 3 +- tests/exeext.test | 1 + tests/exeext4.test | 1 + tests/instdir-ltlib.test | 4 +- tests/instdir-prog.test | 3 +- tests/instfail-libtool.test | 4 +- tests/instfail.test | 3 +- tests/lflags.test | 1 + tests/libtoo10.test | 4 +- tests/libtoo11.test | 4 +- tests/ltorder.test | 4 +- tests/nostdinc.test | 1 + tests/parallel-tests4.test | 1 + tests/parallel-tests5.test | 2 +- tests/parallel-tests7.test | 1 + tests/pr287.test | 3 +- tests/regex.test | 3 +- tests/silent.test | 3 +- tests/silent3.test | 2 +- tests/silent5.test | 2 +- tests/silent9.test | 2 +- tests/silentlex.test | 2 +- tests/silentyacc.test | 2 +- tests/specflg10.test | 4 +- tests/stdinc.test | 3 +- tests/strip.test | 1 + tests/subdirbuiltsources.test | 3 +- tests/subobj5.test | 3 +- tests/subst2.test | 3 +- tests/suffix10.test | 2 +- tests/suffix11.test | 1 + tests/suffix12.test | 1 + tests/suffix13.test | 1 + tests/transform2.test | 4 ++- tests/upc.test | 3 +- tests/upc3.test | 3 +- tests/vala4.test | 4 +- tests/yacc7.test | 5 ++- tests/yflags.test | 1 + 61 files changed, 176 insertions(+), 59 deletions(-) diff --git a/ChangeLog b/ChangeLog index 369e27e..4f040e4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,76 @@ 2010-06-22 Stefano Lattarini <stefano.lattar...@gmail.com> + Make sure all tests needing C compiler require it explicitly. + The list of the test scripts which needed a C compiler but + failed to require it explicitly was found by running (in the + `tests/' directory): + $ CC=no make check -j24 + and seeing which tests reported FAIL instead of SKIP. + After the present change, all those previously failing tests + correctly report SKIP. + * tests/aclocal4.test ($required): Add `cc'. + * tests/ansi.test: Likewise. + * tests/check5.test: Likewise. + * tests/check6.test: Likewise. + * tests/check7.test: Likewise. + * tests/check8.test: Likewise. + * tests/check9.test: Likewise. + * tests/cond11.test: Likewise. + * tests/cond21.test: Likewise. + * tests/cond22.test: Likewise. + * tests/cond30.test: Likewise. + * tests/cond31.test: Likewise. + * tests/cond32.test: Likewise. + * tests/cond34.test: Likewise. + * tests/cond39.test: Likewise. + * tests/cond5.test: Likewise. + * tests/condd.test: Likewise. + * tests/depcomp6.test: Likewise. + * tests/depcomp7.test: Likewise. + * tests/depend5.test: Likewise. + * tests/distcleancheck.test: Likewise. + * tests/distname.test: Likewise. + * tests/exeext.test: Likewise. + * tests/exeext4.test: Likewise. + * tests/instdir-ltlib.test: Likewise. + * tests/instdir-prog.test: Likewise. + * tests/instfail-libtool.test: Likewise. + * tests/instfail.test: Likewise. + * tests/lflags.test: Likewise. + * tests/libtoo10.test: Likewise. + * tests/libtoo11.test: Likewise. + * tests/ltorder.test: Likewise. + * tests/nostdinc.test: Likewise. + * tests/parallel-tests4.test: Likewise. + * tests/parallel-tests5.test: Likewise. + * tests/parallel-tests7.test: Likewise. + * tests/pr287.test: Likewise. + * tests/regex.test: Likewise. + * tests/silent.test: Likewise. + * tests/silent3.test: Likewise. + * tests/silent5.test: Likewise. + * tests/silent9.test: Likewise. + * tests/silentlex.test: Likewise. + * tests/silentyacc.test: Likewise. + * tests/specflg10.test: Likewise. + * tests/stdinc.test: Likewise. + * tests/strip.test: Likewise. + * tests/subdirbuiltsources.test: Likewise. + * tests/subobj5.test: Likewise. + * tests/subst2.test: Likewise. + * tests/suffix10.test: Likewise. + * tests/suffix11.test: Likewise. + * tests/suffix12.test: Likewise. + * tests/suffix13.test: Likewise. + * tests/transform2.test: Likewise. + * tests/upc.test: Likewise. + * tests/upc3.test: Likewise. + * tests/vala4.test: Likewise. + * tests/yacc7.test: Likewise. + * tests/yflags.test: Likewise. + +2010-06-22 Stefano Lattarini <stefano.lattar...@gmail.com> + Do not SKIP a test on a command failing with `77' exit status. When, in a test script using the `errexit' (`-e') shell flag, a command failed with status `77' the global test outcome was diff --git a/tests/aclocal4.test b/tests/aclocal4.test index 9fa96ec..907890a 100755 --- a/tests/aclocal4.test +++ b/tests/aclocal4.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2003 Free Software Foundation, Inc. +# Copyright (C) 2003, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -18,7 +18,7 @@ # Report from Jim Meyering. # We need GNU make for the `rebuild rules' to be triggered. -required=GNUmake +required='cc GNUmake' . ./defs || Exit 1 set -e diff --git a/tests/ansi.test b/tests/ansi.test index c0778c6..6b95561 100755 --- a/tests/ansi.test +++ b/tests/ansi.test @@ -18,6 +18,7 @@ # Test for bug where ansi2knr.c is not included in distribution. # From François Pinard. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/check5.test b/tests/check5.test index 7113e1b..79863ca 100755 --- a/tests/check5.test +++ b/tests/check5.test @@ -17,6 +17,7 @@ # Test TESTS = $(check_PROGRAMS) +required=cc . ./defs || Exit 1 set -e diff --git a/tests/check6.test b/tests/check6.test index e32499c..2d5de5a 100755 --- a/tests/check6.test +++ b/tests/check6.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2006 Free Software Foundation, Inc. +# Copyright (C) 2006, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,6 +17,7 @@ # Test for PR 400: XFAIL_TESTS delimited by TABs. # Also test that Solaris make VPATH rewriting is honored +required=cc . ./defs || Exit 1 set -e diff --git a/tests/check7.test b/tests/check7.test index 1653a8d..9e9b18d 100755 --- a/tests/check7.test +++ b/tests/check7.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2007 Free Software Foundation, Inc. +# Copyright (C) 2007, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +16,7 @@ # Check EXEEXT extension for XFAIL_TESTS. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/check8.test b/tests/check8.test index dc8d3dd..9fcebe8 100755 --- a/tests/check8.test +++ b/tests/check8.test @@ -16,6 +16,7 @@ # Check subdir TESTS. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/check9.test b/tests/check9.test index c80d780..62d4d50 100755 --- a/tests/check9.test +++ b/tests/check9.test @@ -18,6 +18,7 @@ # Note that in this test, we rely on the .test extension for the # substituted names: this is necessary for parallel-tests. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/cond11.test b/tests/cond11.test index 15c6c2a..e243753 100755 --- a/tests/cond11.test +++ b/tests/cond11.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2001, 2002, 2003 Free Software Foundation, Inc. +# Copyright (C) 2001, 2002, 2003, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -18,6 +18,7 @@ # This checks that, if LDADD is set from a conditional variable # and an AC_SUBST, the _DEPENDENCIES variable is set correctly. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/cond21.test b/tests/cond21.test index 160c76f..87dcba4 100755 --- a/tests/cond21.test +++ b/tests/cond21.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2002, 2005 Free Software Foundation, Inc. +# Copyright (C) 2002, 2005, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +16,7 @@ # Check for use of = and += in different conditions. +required=cc . ./defs || Exit 1 cat >> configure.in << 'END' diff --git a/tests/cond22.test b/tests/cond22.test index 4ef1967..804af21 100755 --- a/tests/cond22.test +++ b/tests/cond22.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2002, 2003 Free Software Foundation, Inc. +# Copyright (C) 2002, 2003, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,6 +17,7 @@ # Regression test for bug when sources listed in conditional. # Report from Richard Boulton. PR/326. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/cond30.test b/tests/cond30.test index e092c45..6c050f5 100755 --- a/tests/cond30.test +++ b/tests/cond30.test @@ -1,5 +1,5 @@ #!/bin/sh -# Copyright (C) 2003, 2004 Free Software Foundation, Inc. +# Copyright (C) 2003, 2004, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,7 +16,8 @@ # For PR/352: make sure we support bin_PROGRAMS being defined conditionally. -. ./defs +required=cc +. ./defs || Exit 1 set -e diff --git a/tests/cond31.test b/tests/cond31.test index 4975ef4..47cffc7 100755 --- a/tests/cond31.test +++ b/tests/cond31.test @@ -1,5 +1,5 @@ #!/bin/sh -# Copyright (C) 2003 Free Software Foundation, Inc. +# Copyright (C) 2003, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,7 +16,8 @@ # Make sure we define conditional _DEPENDENCIES correctly. -. ./defs +required=cc +. ./defs || Exit 1 set -e diff --git a/tests/cond32.test b/tests/cond32.test index ae5c8c6..63114ab 100755 --- a/tests/cond32.test +++ b/tests/cond32.test @@ -1,5 +1,5 @@ #!/bin/sh -# Copyright (C) 2003, 2006 Free Software Foundation, Inc. +# Copyright (C) 2003, 2006, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,7 +16,8 @@ # Make sure the user can override a conditional _DEPENDENCIES. -. ./defs +required=cc +. ./defs || Exit 1 set -e diff --git a/tests/cond34.test b/tests/cond34.test index 9e42eea..6bad520 100755 --- a/tests/cond34.test +++ b/tests/cond34.test @@ -1,5 +1,5 @@ #!/bin/sh -# Copyright (C) 2004 Free Software Foundation, Inc. +# Copyright (C) 2004, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,7 +17,8 @@ # Check for _DEPDENDENCIES definition with conditional _LDADD. # Report from Elena A. Vengerova -. ./defs +required=cc +. ./defs || Exit 1 set -e diff --git a/tests/cond39.test b/tests/cond39.test index 8d96595..5a2eca4 100755 --- a/tests/cond39.test +++ b/tests/cond39.test @@ -20,7 +20,8 @@ # Build either as CONFIG_FILE or as PROGRAM. -. ./defs +required=cc +. ./defs || Exit 1 set -e mkdir sub diff --git a/tests/cond5.test b/tests/cond5.test index 531cda8..3a8192b 100755 --- a/tests/cond5.test +++ b/tests/cond5.test @@ -1,5 +1,6 @@ #! /bin/sh -# Copyright (C) 1998, 1999, 2001, 2002 Free Software Foundation, Inc. +# Copyright (C) 1998, 1999, 2001, 2002, 2010 Free Software Foundation, +# Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +17,7 @@ # Yet another sources-in-conditional test. Report from Tim Goodwin. +required=cc . ./defs || Exit 1 cat > configure.in << 'END' diff --git a/tests/condd.test b/tests/condd.test index 0e9b6e8..5cfe5be 100755 --- a/tests/condd.test +++ b/tests/condd.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2001, 2002, 2004 Free Software Foundation, Inc. +# Copyright (C) 2001, 2002, 2004, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +16,7 @@ # Test for bug in conditionals. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/depcomp6.test b/tests/depcomp6.test index 0b6a7f5..f46904a 100755 --- a/tests/depcomp6.test +++ b/tests/depcomp6.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2006 Free Software Foundation, Inc. +# Copyright (C) 2006, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +16,7 @@ # Check dependency generation (non libtool case). +required=cc . ./defs || Exit 1 set -e diff --git a/tests/depcomp7.test b/tests/depcomp7.test index 67702c7..b25d8d4 100755 --- a/tests/depcomp7.test +++ b/tests/depcomp7.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2006, 2007 Free Software Foundation, Inc. +# Copyright (C) 2006, 2007, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,7 +16,7 @@ # Check dependency generation (libtool case). -required='libtoolize' +required='cc libtoolize' . ./defs || Exit 1 set -e diff --git a/tests/depend5.test b/tests/depend5.test index 0d9be3b..9c71f1a 100755 --- a/tests/depend5.test +++ b/tests/depend5.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2008, 2009 Free Software Foundation, Inc. +# Copyright (C) 2008, 2009, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,6 +17,7 @@ # Check that _AM_OUTPUT_DEPENDENCY_COMMANDS works with eval-style # quoting in $CONFIG_FILES, done by newer Autoconf. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/distcleancheck.test b/tests/distcleancheck.test index 8603329..3b32315 100755 --- a/tests/distcleancheck.test +++ b/tests/distcleancheck.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2008, 2009 Free Software Foundation, Inc. +# Copyright (C) 2008, 2009, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,6 +17,7 @@ # Make sure the suggested `distcleancheck_listfiles' in the manual works. # The example Makefile.am we use is from the FAQ entry `distcleancheck'. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/distname.test b/tests/distname.test index 6c18608..75a9707 100755 --- a/tests/distname.test +++ b/tests/distname.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2001, 2002, 2004 Free Software Foundation, Inc. +# Copyright (C) 2001, 2002, 2004, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,6 +17,7 @@ # Test of names in tar file. # From Rainer Orth +required=cc . ./defs || Exit 1 cat > configure.in << 'END' diff --git a/tests/exeext.test b/tests/exeext.test index 3fd42a8..5784954 100755 --- a/tests/exeext.test +++ b/tests/exeext.test @@ -21,6 +21,7 @@ # Also make sure the old definitions of bin_PROGRAMS and friend # aren't left around. Report from Jim Meyering. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/exeext4.test b/tests/exeext4.test index e6cfe7d..0d995fa 100755 --- a/tests/exeext4.test +++ b/tests/exeext4.test @@ -17,6 +17,7 @@ # Make sure $(EXEEXT) is appended to programs and to tests that are # programs, but not to @substituti...@. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/instdir-ltlib.test b/tests/instdir-ltlib.test index 1fb4f37..c651373 100755 --- a/tests/instdir-ltlib.test +++ b/tests/instdir-ltlib.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2009 Free Software Foundation, Inc. +# Copyright (C) 2009, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,7 +17,7 @@ # If $(libdir) is the empty string, then nothing should be installed there. # This test exercises the libtool code paths. -required=libtoolize +required='cc libtoolize' . ./defs || Exit 1 set -e diff --git a/tests/instdir-prog.test b/tests/instdir-prog.test index 6a73b75..789d9be 100755 --- a/tests/instdir-prog.test +++ b/tests/instdir-prog.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2009 Free Software Foundation, Inc. +# Copyright (C) 2009, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,6 +17,7 @@ # If $(bindir) is the empty string, then nothing should be installed there. # This test exercises the prog and libs code paths. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/instfail-libtool.test b/tests/instfail-libtool.test index 1e756a6..a3e2259 100755 --- a/tests/instfail-libtool.test +++ b/tests/instfail-libtool.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2008 Free Software Foundation, Inc. +# Copyright (C) 2008, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -19,7 +19,7 @@ # This is the libtool sister test of instfail.test -required='libtool libtoolize' +required='cc libtool libtoolize' . ./defs || Exit 1 set -e diff --git a/tests/instfail.test b/tests/instfail.test index 38a1c9c..968b561 100755 --- a/tests/instfail.test +++ b/tests/instfail.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2008 Free Software Foundation, Inc. +# Copyright (C) 2008, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -19,6 +19,7 @@ # This test has a few sister tests, for java, info, libtool. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/lflags.test b/tests/lflags.test index 97de608..d677e76 100755 --- a/tests/lflags.test +++ b/tests/lflags.test @@ -19,6 +19,7 @@ # Please keep this in sync with the sister tests lflags2.test, yflags.test # and yflags2.test +required=cc . ./defs || Exit 1 set -e diff --git a/tests/libtoo10.test b/tests/libtoo10.test index 51a68d4..718b30d 100755 --- a/tests/libtoo10.test +++ b/tests/libtoo10.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2007, 2009 Free Software Foundation, Inc. +# Copyright (C) 2007, 2009, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,7 +17,7 @@ # Make sure .libs directories are removed for _PROGRAMS. # Report from Guillermo Ontañón. -required=libtoolize +required='cc libtoolize' . ./defs || Exit 1 set -e diff --git a/tests/libtoo11.test b/tests/libtoo11.test index 850ca82..14bd3a6 100755 --- a/tests/libtoo11.test +++ b/tests/libtoo11.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2008 Free Software Foundation, Inc. +# Copyright (C) 2008, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,7 +17,7 @@ # Make sure config.lt is removed with Libtool 2.2.x's LT_OUTPUT. # Report by Charles Wilson. -required=libtoolize +required='cc libtoolize' . ./defs || Exit 1 set -e diff --git a/tests/ltorder.test b/tests/ltorder.test index 0f69211..0eb4db8 100755 --- a/tests/ltorder.test +++ b/tests/ltorder.test @@ -1,5 +1,5 @@ #!/bin/sh -# Copyright (C) 2008 Free Software Foundation, Inc. +# Copyright (C) 2008, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,7 +16,7 @@ # Test for correct installation order of nobase libtool libraries. -required='libtoolize' +required='cc libtoolize' . ./defs || Exit 1 set -e diff --git a/tests/nostdinc.test b/tests/nostdinc.test index 43535ef..6bb4c20 100755 --- a/tests/nostdinc.test +++ b/tests/nostdinc.test @@ -16,6 +16,7 @@ # Test to make sure nostdinc option works correctly. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/parallel-tests4.test b/tests/parallel-tests4.test index efe7e8d..8540af9 100755 --- a/tests/parallel-tests4.test +++ b/tests/parallel-tests4.test @@ -18,6 +18,7 @@ # - suffix rules parallel_tests=yes +required=cc . ./defs || Exit 1 set -e diff --git a/tests/parallel-tests5.test b/tests/parallel-tests5.test index c4ff5b9..9cb24f4 100755 --- a/tests/parallel-tests5.test +++ b/tests/parallel-tests5.test @@ -21,7 +21,7 @@ # It merely serves as demonstration. :-) parallel_tests=yes -required=GNUmake +required='cc GNUmake' . ./defs || Exit 1 set -e diff --git a/tests/parallel-tests7.test b/tests/parallel-tests7.test index d01ada1..de91bc4 100755 --- a/tests/parallel-tests7.test +++ b/tests/parallel-tests7.test @@ -18,6 +18,7 @@ # - per-extension test drivers parallel_tests=yes +required=cc . ./defs || Exit 1 set -e diff --git a/tests/pr287.test b/tests/pr287.test index 58553b5..77c808f 100755 --- a/tests/pr287.test +++ b/tests/pr287.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2002, 2007 Free Software Foundation, Inc. +# Copyright (C) 2002, 2007, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +16,7 @@ # Test for PR 287: empty SUBDIRS. +required=cc . ./defs || Exit 1 cat > configure.in << 'END' diff --git a/tests/regex.test b/tests/regex.test index babd92a..a57a2e0 100755 --- a/tests/regex.test +++ b/tests/regex.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2004 Free Software Foundation, Inc. +# Copyright (C) 2004, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +16,7 @@ # Make sure AM_WITH_REGEX compiles and runs. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/silent.test b/tests/silent.test index c91115c..db7919e 100755 --- a/tests/silent.test +++ b/tests/silent.test @@ -18,7 +18,8 @@ # Please keep this file in sync with silent2.test. -. ./defs +required=cc +. ./defs || Exit 1 set -e diff --git a/tests/silent3.test b/tests/silent3.test index d0a0131..4a2f9af 100755 --- a/tests/silent3.test +++ b/tests/silent3.test @@ -18,7 +18,7 @@ # Please keep this file in sync with silent4.test and silent9.test. -required=libtoolize +required='cc libtoolize' . ./defs set -e diff --git a/tests/silent5.test b/tests/silent5.test index e1134e8..b01df28 100755 --- a/tests/silent5.test +++ b/tests/silent5.test @@ -20,7 +20,7 @@ # remove this test script. # FIXME: generic C++/Fortran compilers should suffice here -required='g++ gfortran flex bison' +required='cc g++ gfortran flex bison' . ./defs set -e diff --git a/tests/silent9.test b/tests/silent9.test index 11375f8..27fb492 100755 --- a/tests/silent9.test +++ b/tests/silent9.test @@ -18,7 +18,7 @@ # Please keep this file in sync with silent3.test and silent4.test. -required="libtoolize" +required='cc libtoolize' . ./defs set -e diff --git a/tests/silentlex.test b/tests/silentlex.test index 78e0c7d..57936f4 100755 --- a/tests/silentlex.test +++ b/tests/silentlex.test @@ -16,7 +16,7 @@ # Check silent-rules mode for Lex. -required='flex' +required='cc flex' . ./defs set -e diff --git a/tests/silentyacc.test b/tests/silentyacc.test index ac5f061..336707d 100755 --- a/tests/silentyacc.test +++ b/tests/silentyacc.test @@ -16,7 +16,7 @@ # Check silent-rules mode for Yacc. -required='bison' +required='cc bison' . ./defs set -e diff --git a/tests/specflg10.test b/tests/specflg10.test index efe13f5..76eb346 100755 --- a/tests/specflg10.test +++ b/tests/specflg10.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2008, 2009 Free Software Foundation, Inc. +# Copyright (C) 2008, 2009, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,7 +16,7 @@ # AM_DEFAULT_SOURCE_EXT -required=g++ +required='cc g++' . ./defs || Exit 1 set -e diff --git a/tests/stdinc.test b/tests/stdinc.test index ff914f3..b52ed5f 100755 --- a/tests/stdinc.test +++ b/tests/stdinc.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2007 Free Software Foundation, Inc. +# Copyright (C) 2007, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,6 +17,7 @@ # Test to make sure the standard include order is stable. # Report by Kent Boortz. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/strip.test b/tests/strip.test index 12fe6b4..ed1dbad 100755 --- a/tests/strip.test +++ b/tests/strip.test @@ -16,6 +16,7 @@ # Test for install-strip. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/subdirbuiltsources.test b/tests/subdirbuiltsources.test index 8fe506a..c3299b0 100755 --- a/tests/subdirbuiltsources.test +++ b/tests/subdirbuiltsources.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2001, 2002 Free Software Foundation, Inc. +# Copyright (C) 2001, 2002, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -18,6 +18,7 @@ # A bug occurred where subdirs do not have all-recursive or # all-recursive-am which depended on BUILT_SOURCES. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/subobj5.test b/tests/subobj5.test index 9c9568a..5049c42 100755 --- a/tests/subobj5.test +++ b/tests/subobj5.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2001, 2002, 2004 Free Software Foundation, Inc. +# Copyright (C) 2001, 2002, 2004, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,6 +17,7 @@ # Test of subdir make dist rules. # From Robert Collins +required=cc . ./defs || Exit 1 cat > configure.in << 'END' diff --git a/tests/subst2.test b/tests/subst2.test index 2bbabdd..25d0719 100755 --- a/tests/subst2.test +++ b/tests/subst2.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2003, 2006 Free Software Foundation, Inc. +# Copyright (C) 2003, 2006, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +16,7 @@ # Make sure a multi-line definition cannot be terminated by an empty # line (when there are @substitutions@ inside). +required=cc . ./defs || Exit 1 set -e diff --git a/tests/suffix10.test b/tests/suffix10.test index 131359c..e5ca0d4 100755 --- a/tests/suffix10.test +++ b/tests/suffix10.test @@ -17,7 +17,7 @@ # Make sure that derivations work with .lo too. # (related to PR/37) -required='libtoolize bison' +required='cc libtoolize bison' . ./defs || Exit 1 set -e diff --git a/tests/suffix11.test b/tests/suffix11.test index 91d2cf4..5d926ab 100755 --- a/tests/suffix11.test +++ b/tests/suffix11.test @@ -18,6 +18,7 @@ # PR/371 and PR/372: Reported by Duncan Gibson. # We also check for suffixes containing `-'. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/suffix12.test b/tests/suffix12.test index 21089a5..a6f03e5 100755 --- a/tests/suffix12.test +++ b/tests/suffix12.test @@ -17,6 +17,7 @@ # Tests that Automake understands suffix rules with subdir objects. # Reported by John Ratliff. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/suffix13.test b/tests/suffix13.test index 2b39460..719ed12 100755 --- a/tests/suffix13.test +++ b/tests/suffix13.test @@ -23,6 +23,7 @@ # and subdir objects. # Reported by Florian Briegel. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/transform2.test b/tests/transform2.test index 0f9d5ec..0e1d1a6 100755 --- a/tests/transform2.test +++ b/tests/transform2.test @@ -1,5 +1,6 @@ #! /bin/sh -# Copyright (C) 2002, 2003, 2004, 2007, 2008 Free Software Foundation, Inc. +# Copyright (C) 2002, 2003, 2004, 2007, 2008, 2010 Free Software +# Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -17,6 +18,7 @@ # Make sure that --program-transform works even when multiple files are # collapsed. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/upc.test b/tests/upc.test index 725166c..542361c 100755 --- a/tests/upc.test +++ b/tests/upc.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2006 Free Software Foundation, Inc. +# Copyright (C) 2006, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +16,7 @@ # A simple Hello World for UPC. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/upc3.test b/tests/upc3.test index 870c66e..32e3119 100755 --- a/tests/upc3.test +++ b/tests/upc3.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2006 Free Software Foundation, Inc. +# Copyright (C) 2006, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -16,6 +16,7 @@ # Test that C and Unified Parallel C link safely. +required=cc . ./defs || Exit 1 set -e diff --git a/tests/vala4.test b/tests/vala4.test index 7a15ebe..086a7d7 100755 --- a/tests/vala4.test +++ b/tests/vala4.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2008, 2009 Free Software Foundation, Inc. +# Copyright (C) 2008, 2009, 2010 Free Software Foundation, Inc. # # This file is part of GNU Automake. # @@ -20,7 +20,7 @@ # Test AM_PROG_VALAC. -required=libtoolize +required='cc libtoolize' . ./defs || Exit 1 set -e diff --git a/tests/yacc7.test b/tests/yacc7.test index 2edd15c..591a679 100755 --- a/tests/yacc7.test +++ b/tests/yacc7.test @@ -1,5 +1,6 @@ #! /bin/sh -# Copyright (C) 2001, 2002, 2003, 2004 Free Software Foundation, Inc. +# Copyright (C) 2001, 2002, 2003, 2004, 2010 Free Software Foundation, +# Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -20,7 +21,7 @@ # Also check that the sources of the generated parser are distributed. # PR/47. -required=bison +required='cc bison' . ./defs || Exit 1 cat >> configure.in << 'END' diff --git a/tests/yflags.test b/tests/yflags.test index fcb0c64..eefdefe 100755 --- a/tests/yflags.test +++ b/tests/yflags.test @@ -19,6 +19,7 @@ # Please keep this in sync with the sister tests yflags2.test, lflags.test # and lflags2.test +required=cc . ./defs || Exit 1 set -e -- 1.6.5
From 5205246b63047f37ad39c1d102f4d64792e43546 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Wed, 23 Jun 2010 08:11:43 +0200 Subject: [PATCH 4/4] Fixup requirements introduced by previous change. * tests/libtoo10.test: Require `gcc', not `cc', as the test might fail with some non-GNU C compilers. * tests/ltorder.test: Likewise. --- ChangeLog | 7 +++++++ tests/libtoo10.test | 3 ++- tests/ltorder.test | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4f040e4..b40f236 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2010-06-22 Stefano Lattarini <stefano.lattar...@gmail.com> + Fixup requirements introduced by previous change. + * tests/libtoo10.test: Require `gcc', not `cc', as the test + might fail with some non-GNU C compilers. + * tests/ltorder.test: Likewise. + +2010-06-22 Stefano Lattarini <stefano.lattar...@gmail.com> + Make sure all tests needing C compiler require it explicitly. The list of the test scripts which needed a C compiler but failed to require it explicitly was found by running (in the diff --git a/tests/libtoo10.test b/tests/libtoo10.test index 718b30d..b3df4e8 100755 --- a/tests/libtoo10.test +++ b/tests/libtoo10.test @@ -17,8 +17,9 @@ # Make sure .libs directories are removed for _PROGRAMS. # Report from Guillermo Ontañón. -required='cc libtoolize' +required='gcc libtoolize' . ./defs || Exit 1 + set -e cat >> configure.in << 'END' diff --git a/tests/ltorder.test b/tests/ltorder.test index 0eb4db8..fbb8c37 100755 --- a/tests/ltorder.test +++ b/tests/ltorder.test @@ -16,7 +16,7 @@ # Test for correct installation order of nobase libtool libraries. -required='cc libtoolize' +required='gcc libtoolize' . ./defs || Exit 1 set -e -- 1.6.5