Another cosmetic change adding an IMHO useful comment to an idiom in a
test script.
* tests/ext.test: Add a comment explaining why an apparently
useless `if' statement is indeed required.
---
ChangeLog | 4 ++++
tests/ext.test | 4 ++++
2 files changed, 8 insertions(+), 0 deletions(-)
From ade0ecc7b51c97d4b7951625003fd2b4884798c6 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <stefano.lattar...@gmail.com>
Date: Sun, 13 Jun 2010 22:37:39 +0200
Subject: [PATCH] Add useful comment in test script ext.test.
* tests/ext.test: Add a comment explaining why an apparently
useless `if' statement is indeed required.
---
ChangeLog | 4 ++++
tests/ext.test | 4 ++++
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index b5f1433..be12239 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
2010-06-13 Stefano Lattarini <stefano.lattar...@gmail.com>
+ Add useful comment in test script ext.test.
+ * tests/ext.test: Add a comment explaining why an apparently
+ useless `if' statement is indeed required.
+
Add useful comment in test script obsolete.test.
* tests/obsolte.test: Add a comment explaining why we need
an indirection in adding $AUTOUPDATE to $required.
diff --git a/tests/ext.test b/tests/ext.test
index 9340673..af2eab2 100755
--- a/tests/ext.test
+++ b/tests/ext.test
@@ -38,6 +38,10 @@ $AUTOMAKE
for ext in f for f90 f95 F F90 F95 r m upc
do
+ # Some versions of the BSD shell wrongly exit when `set -e' is active
+ # if the last command within a compound statement fails and is guarded
+ # by an && only. So we play safe and use the following idiom, instead
+ # of the apparently simpler `grep ... && Exit 1'.
if grep "^$ext\.o:" Makefile.in; then Exit 1; else :; fi
grep "^\.$ext\.o:" Makefile.in
done
--
1.6.5
