Enable the shell `errexit' flag in `tests/dejagnu7.test', so that previously unchecked failures now cause the whole test to fail. Also, avoid unportable use of fgrep option `-e'.
Regards, Stefano
From 9b487b1e65ca5d0e3361c484fe624a729c9245fc Mon Sep 17 00:00:00 2001 From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Thu, 6 May 2010 03:18:45 +0200 Subject: [PATCH] Avoid possible false negatives in dejagnu7.test. * tests/dejagnu7.test: Enable shell `errexit' flag. Also, avoid unportable use of fgrep option `-e'. --- ChangeLog | 6 ++++++ tests/dejagnu7.test | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 71b0d9b..949b163 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2010-05-06 Stefano Lattarini <stefano.lattar...@gmail.com> + + Avoid possible false negatives in dejagnu7.test. + * tests/dejagnu7.test: Enable shell `errexit' flag. Also, avoid + unportable use of fgrep option `-e'. + 2010-04-25 Ralf Wildenhues <ralf.wildenh...@gmx.de> Warning and error message formatting cleanups. diff --git a/tests/dejagnu7.test b/tests/dejagnu7.test index 9abd428..552c2ca 100755 --- a/tests/dejagnu7.test +++ b/tests/dejagnu7.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2003 Free Software Foundation, Inc. +# Copyright (C) 2003, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -20,8 +20,10 @@ required=runtest . ./defs || Exit 1 +set -e + # Check whether DejaGnu supports --status -runtest --help | $FGREP -e --status || Exit 77 +runtest --help | grep '.*--status' || Exit 77 cat > failtcl << 'END' #! /bin/sh -- 1.6.5
