Hello automakers.
I'll soon post a couple of patches enabling the `errexit' a.k.a. `set -e'
shell flag unconditionally in all test scripts. This helps making the
behaviour of different test scripts globally more consistent, and helps
catching potential bugs that could lead to false negatives (which are
very bad in a testsuite IMO).
By the way, the patches does actually fix "for free" some test scripts
in which failures could have easily gone undetected; this happended
because these tests acted like the `errexit' flag was active, but forgot
to ever set it.
An outstanding example of this problem is the test `cond46.test',
in which the `errexit' flag is off, and which "checks" various expected
Automake failures using the idiom:
AUTOMAKE_fails
grep DIAGNOSTIC stderr
thus forgetting to call `Exit 1' if the expected diagnostic is not found,
i.e. not signaling the error to the test driver.
Other examples of this problem can be found e.g. in `confh5.test' and
`dejagnu7.test'.
Regards,
Stefano
