Hi Ralf, Thanks for the review. I agree with most of your remarks.
On Wed, Sep 23, 2009 at 6:42 AM, Ralf Wildenhues <ralf.wildenh...@gmx.de> wrote: > * Jack Kelly wrote on Tue, Sep 22, 2009 at 04:33:27AM CEST: >> + tagvars and verbose vars. >> + * automake.in (define_verbose_tagvar): increase spacing to 12 to >> + accommodate MAKEINFOHTML. > > Ugh, that's very ugly, because it will make it very difficult to align > the target name with the abbreviation used for the command, when the > build is rushing by. I found 6 to be close to the maximum tolerable > length. Can we either agree to create unaligned output, or abbreviate > MAKEINFOHTML somehow? Can we go to 8? If we have 8, I can change this to `INFOHTML' and it means `MAKEINFO' is still OK. Currently, the $(AM_V_FOO) output is left-aligned. What if we make it right-aligned with 2 spaces between the end of the tag and $...@? The only argument I can see against this is that things like CC and CCLD won't line up any more. Perhaps we could right-align only things that end in LD or are very long, and add an extra 2 spaces otherwise? Another alternative is to add an arg to define_verbose_tagvar to add 2 spaces of padding because there's a linker to worry about as well. I'm interested in your thoughts. I could do this as a separate patch and then finish the texinfo patch later. -- Jack
