Ralf Wildenhues wrote: > Hi Peter, > > * Peter O'Gorman wrote on Tue, May 19, 2009 at 06:01:49PM CEST: >> Ralf Wildenhues wrote: >>> * Peter O'Gorman wrote on Mon, May 18, 2009 at 03:43:00AM CEST: >>>> The instmany-python test is failing for me on Mac OS X 10.5.7. Looks >>>> like it is trying to install things into /Library/Python, and as I did >>>> not run make check as the superuser, can't. >>> Ouch. This looks like a bug in python.m4, or like python doing >>> something we do not expect. In any case, configuring with a local >>> --prefix should not cause us to try to install files below /Library. >> Another Apple bug. >> http://opensource.apple.com/source/python/python-30.1.3/fix/sysconfig.py.ed >> >> The ed script patches sysconfig.py so that it ignores prefix and just >> returns /Library/Python. >> >> I will file a bug with Apple later today. > > Thank you. > > Meanwhile, however, we should do something about this issue. Automake > should not be blamed for causing users driving as root to scribble over > the python files from their distribution, nor those not driving as root > to not be able to put their python files below $HOME or so. > > Can you check whether the patch I pointed out exposes the problem, or > whether it existed before? From the ed script above I can't tell, and > the instmany-python.test is new in this release. > > Any suggestions for a good workaround? Like, honor the suggestion from > python only if $prefix was NONE, /usr/local or /usr, and $host_os = > darwin? (Even that sounds ugly as it requires AC_CANONICAL_HOST.)
This patch works for me. Thoughts? checking for python script directory... ${prefix}/lib/python2.6/site-packages checking for python extension module directory... ${exec_prefix}/lib/python2.6/site-packages 2009-??-?? Peter O'Gorman <pe...@pogma.com> m4/python.m4: Ensure that pythondir and pyexecdir are below ${prefix}. Peter -- Peter O'Gorman http://pogma.com
diff --git a/m4/python.m4 b/m4/python.m4 index 239285f..852a50d 100644 --- a/m4/python.m4 +++ b/m4/python.m4 @@ -128,6 +128,12 @@ python2.1 python2.0]) am__strip_prefix=`echo "$am_py_prefix" | sed 's|.|.|g'` am_cv_python_pythondir=`echo "$am_cv_python_pythondir" | sed "s,^$am__strip_prefix,$PYTHON_PREFIX,"` ;; + *) + case $am_py_prefix in + /usr|/usr/local|/System/Library/*) ;; + *) am_cv_python_pythondir="$PYTHON_PREFIX/lib/python$PYTHON_VERSION/site-packages" ;; + esac + ;; esac ]) AC_SUBST([pythondir], [$am_cv_python_pythondir]) @@ -158,6 +164,12 @@ python2.1 python2.0]) am__strip_prefix=`echo "$am_py_exec_prefix" | sed 's|.|.|g'` am_cv_python_pyexecdir=`echo "$am_cv_python_pyexecdir" | sed "s,^$am__strip_prefix,$PYTHON_EXEC_PREFIX,"` ;; + *) + case $am_py_exec_prefix in + /usr|/usr/local|/System/Library/*) ;; + *) am_cv_python_pyexecdir="$PYTHON_EXEC_PREFIX/lib/python$PYTHON_VERSION/site-packages" ;; + esac + ;; esac ]) AC_SUBST([pyexecdir], [$am_cv_python_pyexecdir])