My changes to patch 01 introduced a sed s,...,\n, command, which is of course not portable. It led to bogus summary output on stdout with Solaris sed and others, as documented by POSIX.
Cheers, Ralf parallel-tests: Fix summary output. * lib/am/check.am (am__text_box): Fix unportable sed script, replacing `\n' in the right hand side of an `s' command with a literal newline. Kudos to Bruno Haible for the newline idea. * tests/parallel-tests.test: Update test to expose this. diff --git a/lib/am/check.am b/lib/am/check.am index 77e6271..c01a25a 100644 --- a/lib/am/check.am +++ b/lib/am/check.am @@ -75,7 +75,8 @@ am__rst_title = sed 's/.*/ & /;h;s/./=/g;p;x;p;g;p;s/.*//' am__rst_section = sed 'p;s/./=/g;p;g' # Put stdin (possibly several lines separated by ". ") in a box. -am__text_box = sed 's/\. /\n/g' | sed '/^$$/d' | \ +am__text_box = { nlinit=`echo 'nl="'; echo '"'`; eval "$$nlinit"; \ + sed "s/\\. /\\$$nl/g"; } | sed '/^$$/d' | \ $(AWK) '{ if (final) final = final "\n" $$0; else final = $$0; }\ max < length($$0) { max = length($$0); } \ END { \ diff --git a/tests/parallel-tests.test b/tests/parallel-tests.test index 6e4b878..2482f30 100755 --- a/tests/parallel-tests.test +++ b/tests/parallel-tests.test @@ -70,6 +70,8 @@ test `grep -c '^FAIL' mylog.log` -eq 1 test -f baz.log test -f bar.log test -f foo.log +# The summary should be formatted correctly. +grep 'failedn' stdout && Exit 1 # clean should remove all log files (but not more). : > unrelated.log