Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes: > Somebody please check what I'm currently not seeing in the m4 fu I > tried (the test fails, because there is something wrong in > m4/maintainer.m4). Also a review of the rest would be nice as well. >
> +[m4_if(m4_default([$1], [disable]), s/m4_if/m4_case/ > + [enable], [m4_define([am_maintainer_other], [disable])], > + [disable], [m4_define([am_maintainer_other], [enable])], > + [m4_define([am_maintainer_other], [enable]) > + m4_warning([unexpected argument to AM@&t <at> _MAINTAINER_MODE: > $1])]) > +AC_MSG_CHECKING([whether to am_maintainer_other maintainer-specific portions of Makefiles]) > + dnl maintainer-mode's default is 'disable' unless 'enable' is passed > + AC_ARG_ENABLE([maintainer-mode], > +[ --][am_maintainer_other][-maintainer-mode am_maintainer_other make rules and dependencies not useful > (and sometimes confusing) to the casual installer], I'd use AS_HELP_STRING here. Something like (untested): AC_ARG_ENABLE([maintainer-mode], [AS_HELP_STRING([--am_maintainer_other-maintainer-mode], am_maintainer_other[ make rules and dependencies not useful (and sometimes confusing) to the casual installer])], The rest of the patch looked okay at a cursory glance. -- Eric Blake
