On Thu, 18 Oct 2007 06:36:49 -0600, Eric Blake <[EMAIL PROTECTED]> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> [Adding automake-patches; other lists can be dropped in replies.]
Dropped
> > > According to H.Merijn Brand on 10/18/2007 1:43 AM:
> > > >
> > > > Please convince the GNU world to add 'make test' as alias for
> > > > 'make check'.
> > >
> > > It won't work for coreutils, where test is the name of a built program.
> > > That's why the GNU Coding Standards mandate 'make check', but mention
> > > nothing about 'make test'. However, patches to automake are welcome.
> >
> > like attached?
> >
> > --
> > H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
>
> Do you have copyright assignment for automake?
Not that I am aware of. Can you expand on this?
> By the time you fix this patch to add documentation, it might
> not be trivial any longer.
> > @@ -563,7 +563,7 @@ documentation targets, and that the `che
> > # Then, define the other targets needed by Automake Makefiles.
> > .PHONY: dvi pdf ps info html check
> > dvi pdf ps info html:
> > - check: test
> > + test check: test
>
> That looks like a circular dependency to me.
True, that chunk should/could be dropped.
Revised patch attached.
> And you need to make sure that automake still works for coreutils,
> which builds a test utility.
That could prove to be much harder, as I do not have automake/autogen
installed on most of these HP-UX boxes
I tried to build 1.10 on HP-UX 11.11 (11iv1) with HP C-ANSI-C 64bit
/pro/3gl/GNU/automake-1.10 111 > configure --prefix=/pro/local --disable-nls
:
:
/pro/3gl/GNU/automake-1.10 112 > make
Making all in lib
:
:
/pro/3gl/GNU/automake-1.10 113 > make test
Making check in lib
:
make[4]: Entering directory `/pro/3gl/GNU/automake-1.10/lib/Automake/tests'
PASS: Condition.pl
PASS: DisjConditions.pl
PASS: Version.pl
PASS: Wrap.pl
==================
All 4 tests passed
==================
:
make[2]: Entering directory `/pro/3gl/GNU/automake-1.10/tests'
FAIL: aclibobj.test
FAIL: aclocal.test
PASS: aclocal3.test
FAIL: aclocal4.test
FAIL: aclocal5.test
FAIL: aclocal6.test
etc etc
maybe it's not a wise idea to install that
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/diff -pur automake-1.10/Makefile.in automake-1.10_01/Makefile.in
--- automake-1.10/Makefile.in 2006-10-15 19:25:23 +0200
+++ automake-1.10_01/Makefile.in 2007-10-18 15:17:37 +0200
@@ -532,7 +532,7 @@ distcleancheck: distclean
$(distcleancheck_listfiles) ; \
exit 1; } >&2
check-am: all-am
-check: check-recursive
+test check: check-recursive
all-am: Makefile $(SCRIPTS)
installdirs: installdirs-recursive
installdirs-am:
diff -pur automake-1.10/automake.in automake-1.10_01/automake.in
--- automake-1.10/automake.in 2006-10-15 18:19:37 +0200
+++ automake-1.10_01/automake.in 2007-10-18 15:17:00 +0200
@@ -4400,7 +4400,7 @@ sub do_check_merge_target ()
depend '.PHONY', 'check', 'check-am';
# Handle recursion. We have to honor BUILT_SOURCES like for `all:'.
- $output_rules .= ("check: "
+ $output_rules .= ("test check: "
. (var ('BUILT_SOURCES')
? "\$(BUILT_SOURCES)\n\t\$(MAKE) \$(AM_MAKEFLAGS) "
: '')
diff -pur automake-1.10/doc/Makefile.in automake-1.10_01/doc/Makefile.in
--- automake-1.10/doc/Makefile.in 2006-10-15 19:25:24 +0200
+++ automake-1.10_01/doc/Makefile.in 2007-10-18 15:17:00 +0200
@@ -477,7 +477,7 @@ distdir: $(DISTFILES)
top_distdir="$(top_distdir)" distdir="$(distdir)" \
dist-info
check-am: all-am
-check: check-am
+test check: check-am
all-am: Makefile $(INFO_DEPS) $(DATA)
installdirs:
for dir in "$(DESTDIR)$(infodir)" "$(DESTDIR)$(docdir)"; do \
diff -pur automake-1.10/lib/Automake/Makefile.in automake-1.10_01/lib/Automake/Makefile.in
--- automake-1.10/lib/Automake/Makefile.in 2006-10-15 19:25:24 +0200
+++ automake-1.10_01/lib/Automake/Makefile.in 2007-10-18 15:17:00 +0200
@@ -435,7 +435,7 @@ distdir: $(DISTFILES)
fi; \
done
check-am: all-am
-check: check-recursive
+test check: check-recursive
all-am: Makefile $(DATA)
installdirs: installdirs-recursive
installdirs-am:
diff -pur automake-1.10/lib/Automake/tests/Makefile.in automake-1.10_01/lib/Automake/tests/Makefile.in
--- automake-1.10/lib/Automake/tests/Makefile.in 2006-10-15 19:25:24 +0200
+++ automake-1.10_01/lib/Automake/tests/Makefile.in 2007-10-18 15:17:00 +0200
@@ -280,7 +280,7 @@ distdir: $(DISTFILES)
done
check-am: all-am
$(MAKE) $(AM_MAKEFLAGS) check-TESTS
-check: check-am
+test check: check-am
all-am: Makefile
installdirs:
install: install-am
diff -pur automake-1.10/lib/Makefile.in automake-1.10_01/lib/Makefile.in
--- automake-1.10/lib/Makefile.in 2006-10-15 19:25:25 +0200
+++ automake-1.10_01/lib/Makefile.in 2007-10-18 15:17:00 +0200
@@ -411,7 +411,7 @@ distdir: $(DISTFILES)
fi; \
done
check-am: all-am
-check: check-recursive
+test check: check-recursive
all-am: Makefile $(DATA)
installdirs: installdirs-recursive
installdirs-am:
diff -pur automake-1.10/lib/am/Makefile.in automake-1.10_01/lib/am/Makefile.in
--- automake-1.10/lib/am/Makefile.in 2006-10-15 19:25:24 +0200
+++ automake-1.10_01/lib/am/Makefile.in 2007-10-18 15:17:00 +0200
@@ -268,7 +268,7 @@ distdir: $(DISTFILES)
fi; \
done
check-am: all-am
-check: check-am
+test check: check-am
all-am: Makefile $(DATA)
installdirs:
for dir in "$(DESTDIR)$(amdir)"; do \
diff -pur automake-1.10/m4/Makefile.in automake-1.10_01/m4/Makefile.in
--- automake-1.10/m4/Makefile.in 2006-10-15 19:25:24 +0200
+++ automake-1.10_01/m4/Makefile.in 2007-10-18 15:17:00 +0200
@@ -264,7 +264,7 @@ distdir: $(DISTFILES)
fi; \
done
check-am: all-am
-check: check-am
+test check: check-am
all-am: Makefile $(DATA)
installdirs:
for dir in "$(DESTDIR)$(m4datadir)"; do \
