Hi Noah,

* Noah Misch wrote on Fri, Apr 28, 2006 at 06:14:01AM CEST:
> 
> This patch revamps {Autom4te,Automake}::XFile::lock.

A comment and a couple of questions:

- XFile.pm needs a copyright year update (which I can add, when given
  OK-to-commit).

- AFAICS this causes autom4te to continue but exit with an error status.
  The only difference with parallel make is that the message is
  adjusted.  Is that correct semantics?  Wouldn't it be safer to
  actually fatal() if we are running under parallel make?
  (Take this with a grain of salt; I don't know what I'm talking about.)

- BTW, is there real-world indication of build tools other than
  Automake-created Makefiles that may happen to invoke parallel autom4te
  instances, possibly indirectly?
  (I won't worry about this any further than asking now.)

Interestingly, this host still has lots other test suite failures .. in
another mail.

Cheers, and thanks for working on this!
Ralf

> 2006-04-27  Noah Misch  <[EMAIL PROTECTED]>
> 
>       * lib/Autom4te/XFile.pm (lock): Allow EOPNOTSUPP, besides ENOLCK.  Do
>       not raise fatal errors.  Only mention `make -j' when applicable.


Reply via email to