Hello,
On Wed, Jun 29, 2005 at 11:04:25PM +0200, Alexandre Duret-Lutz wrote:
> I'm installing this on HEAD and branch-1-9.
thanks.
Some nit picking:
> +case "$*" in
> + *-p*) exit 1;;
> +esac
There is no word-splitting of the argument of "case", so you don't
have to quote $*.
> +export PATH
There is no need to call export again, you have already exported it
in the outer shell.
Of course, none of these changes is necessary; it's just a matter
of your taste.
Anyway, a patch is attached.
Stepan
2005-06-30 Stepan Kasal <[EMAIL PROTECTED]>
* tests/mkinst3.test: In the mkdir stub script, there is no need
to quote $* and no need to call "export PATH" again.
Index: tests/mkinst3.test
===================================================================
RCS file: /cvs/automake/automake/tests/mkinst3.test,v
retrieving revision 1.1
diff -u -r1.1 mkinst3.test
--- tests/mkinst3.test 29 Jun 2005 21:08:19 -0000 1.1
+++ tests/mkinst3.test 30 Jun 2005 12:15:48 -0000
@@ -41,11 +41,10 @@
cat >mkdir <<'EOF'
#!/bin/sh
-case "$*" in
+case $* in
*-p*) exit 1;;
esac
PATH=$AM_PATH
-export PATH
exec mkdir "$@"
EOF
