Hello,
On Wed, Jun 29, 2005 at 10:29:11PM +0200, Alexandre Duret-Lutz wrote:
> I'm installing the following on HEAD and branch-1-9.
thank you.
> (I think any justification of why unset must not be used really
> belongs to the Autoconf manual.)
Yes, of course. I sent a question to the autoconf list; I hope we'll
receive an answer from a historician there.
Two tiny comments:
> Václav Haisman [EMAIL PROTECTED]
> Vadim Zeitlin [EMAIL PROTECTED]
> +Vincent Lefevre Vincent Lefevre <[EMAIL PROTECTED]>
It seems this is the first time when you repeat the full name in the email.
> +if test "${TIME_STYLE+set}" = set; then
> + TIME_STYLE=posix-long-iso
> + export TIME_STYLE
> +fi
I see no reason for the `export' here. If it's not exported, it's even
better. We don't set the variable if it's not set, either.
Please find attached a patch which contains both these changes.
Happy summer,
Stepan
2005-06-30 Stepan Kasal <[EMAIL PROTECTED]>
* lib/mdate-sh: Don't export TIME_STYLE; it's even better if it's
not exported.
--- lib/mdate-sh 29 Jun 2005 20:29:24 -0000 1.18
+++ lib/mdate-sh 30 Jun 2005 12:01:58 -0000
@@ -64,7 +64,6 @@
# variable to its documented default.
if test "${TIME_STYLE+set}" = set; then
TIME_STYLE=posix-long-iso
- export TIME_STYLE
fi
save_arg1=$1
--- THANKS 2005-06-30 13:18:18.000000000 +0200
+++ THANKS 2005-06-30 13:15:45.000000000 +0200
@@ -269,7 +269,7 @@
Ulrich Eckhardt [EMAIL PROTECTED]
VĂĄclav Haisman [EMAIL PROTECTED]
Vadim Zeitlin [EMAIL PROTECTED]
-Vincent Lefevre Vincent Lefevre <[EMAIL PROTECTED]>
+Vincent Lefevre [EMAIL PROTECTED]
Volker Boerchers [EMAIL PROTECTED]
Werner John [EMAIL PROTECTED]
Werner Koch [EMAIL PROTECTED]
