> -----Original Message-----
> From: Lars J. Aas [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, July 05, 2000 3:17 PM
> To: [EMAIL PROTECTED]; [EMAIL PROTECTED]
> Subject: Re: [patch] acgeneral.m4 (dirname usage)
> 
> 
> On Wed, Jul 05, 2000 at 03:05:13PM +0200, Lars J. Aas wrote:
> : +define([AC_SHELL_DIRNAME],
> : +[echo "$1" | sed 's%/[[^/][^/]]*$%%'])
> [...]    ^  ^
> : +  ac_dir=`AC_SHELL_DIRNAME("$ac_file")`
> [...]                         ^        ^
> : +    ac_dir=`AC_SHELL_DIRNAME("$ac_file")`
> [...]                           ^        ^
> : +  ac_dest_dir=`AC_SHELL_DIRNAME("$ac_dest")`
>                                    ^        ^
> 
> There's obviously one set of ""s too much here.  Should the 
> redundant pair
> be removed in the macro definition or the macro invocations?
> 

I'd rather suppress them from the macro invokations; when reusing
AC_SHELL_DIRNAME I thus has less to type :-)

Regards,

                Bernard

--------------------------------------------
Bernard Dautrevaux
Microprocess Ing�ni�rie
97 bis, rue de Colombes
92400 COURBEVOIE
FRANCE
Tel:    +33 (0) 1 47 68 80 80
Fax:    +33 (0) 1 47 88 97 85
e-mail: [EMAIL PROTECTED]
                [EMAIL PROTECTED]
-------------------------------------------- 

Reply via email to