Re-sending the below message as it looks like it wasn't posted on the
list (not visible in the archive)...
Le 03/11/2023 à 20:07, Zoddo a écrit :
Hello,
tiziodcaio [1] filed a request to merge discord_arch_electron [2] into
discord-electron [3]:
Please merge due to the name is more into arch standards
[1] https://aur.archlinux.org/account/tiziodcaio/
[2] https://aur.archlinux.org/pkgbase/discord_arch_electron/
[3] https://aur.archlinux.org/pkgbase/discord-electron/
I don't think these packages should be merged. They have the same goal
(using the system electron binary instead of the bundled one) but
"discord-electron" go a step too far in my opinion (patching Krisp -a
proprietary binary module- in the startup script to disable a
signature check).
End-users can do it if they want, but I don't think a package should
ever do such patch automatically. I can't speak for everyone, but I
wouldn't be comfortable if a random package is patching files on my
system at runtime.
See also my last comment on discord_arch_electron about touching files
in /home as a packager:
https://aur.archlinux.org/packages/discord_arch_electron#comment-939243
I agree that the name of the package doesn't follow the guidelines. I
wanted to rename it multiple times since I took it over but I
abandoned as there is no good support for renaming aur packages
(`replaces` doesn't work on aur, even with aur helpers; the old
package just disappear after the merge request, leaving users trying
to understand what happened).
BTW, discord-electron doesn't fully follow naming guidelines too; it
should be "discord-electron-bin" (which is the name I wanted to rename
to) because we aren't building from sources.
Best,
Yohan Prod'homme (Zoddo)
