On Tue, Jan 3, 2023 at 12:03 PM Robin Candau <robincan...@protonmail.com> wrote:
> - I maintain a few packages in the AUR with what I think are > high-quality/clean PKGBUILDs [1]. > > [1] > https://aur.archlinux.org/packages?O=0&SeB=M&K=Antiz&outdated=&SB=p&SO=d&PP=50&submit=Go Hi Robin, I looked at your PKGBUILDs. In general, they look very good! I have a few questions: Regarding clipboard and clipboard-git: Doesn't setting CMAKE_C_FLAGS or CMAKE_CXX_FLAGS make it ignore the CFLAGS and CXXFLAGS in the environment? Regarding unrar-free: Doesn't passing CFLAGS to configure make it ignore the CFLAGS in the environment? Regarding ame and ame-git: You export 'RUSTUP_TOOLCHAIN=nightly'. Does Amethyst require nightly Rust to build? If it doesn't, it would break building on systems using rustup but only the stable toolchain installed. If it does, I think you should makedepend on rustup and ensure the nightly toolchain is installed in prepare(). This would also allow it to build in clean chroots. Regarding malachite: You export 'RUSTUP_TOOLCHAIN=stable'. I think you should just let it use the default toolchain because the stable toolchain might not be installed and using a newer toolchain shouldn't break the build. (In general, I would expect the stable toolchain to be the default, to match the rust package.) Greetings, Jan
