Re: For AUR PKGBUILD checkup

[Frederick Zhang]

And I just realised:

    url="https://github.com/wakatime/$pkgname";
    source=("git+https://github.com/Tatsh/kate-wakatime";)

I think it's better to use the same repository for URL and source.

    conflicts=('kate-wakatime')

Is there already a package named kate-wakatime somewhere? I searched
both official repository and AUR but failed to find one.

On 9/1/23 23:33, Frederick Zhang wrote:

    pkgname=kate-wakatime-git
    pkgver=1.3.10

So is this a VCS package [1] or not?

    pkgdesc=" Kate plugin to interface with WakaTime"

Redundant space at the beginning.

    arch=('x86_64')

Does this build on other architectures?

    url="https://github.com/wakatime/$pkgname";

The URL here uses $pkgname, which has the -git suffix, so it's not a
valid URL.

Another thing is that although this is maintained by WakaTime
organisation in GitHub, it's behind [2] that it was forked from. Is
there any reason to not used [2] instead?

    license=('unknown')

 From their source code: 'you can redistribute it and/or modify it under
the terms of the GNU Library General Public License version 3, or (at
your option) any later version'.

             -DCMAKE_BUILD_TYPE='None' \

Shouldn't this be Release or RelWithDebInfo? [3]

PS: You don't have to send emails in both plaintext and HTML here.

[1] https://wiki.archlinux.org/title/VCS_package_guidelines
[2] https://github.com/Tatsh/kate-wakatime
[3] https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html

On 9/1/23 23:14, Sharafat Karim wrote:

Hi there,

I'm writing to request that my PKGBUILD for /kate-wakatime/ be added to the 
Arch User Repository (AUR). I have tested the PKGBUILD and it works as 
expected. But I'm unsure about this script's formatting or other checkups. I'll 
really appreciate any advice.

Here's my PKGBUILD,

    # Maintainer: sharafat <sharafat two thousand four at gmail>

    pkgname=kate-wakatime-git
    pkgver=1.3.10
    pkgrel=1
    pkgdesc=" Kate plugin to interface with WakaTime"
    arch=('x86_64')
    url="https://github.com/wakatime/$pkgname 
<https://github.com/wakatime/$pkgname>"
    license=('unknown')
    makedepends=('git' 'cmake' 'extra-cmake-modules')
    depends=('kate')
    conflicts=('kate-wakatime')
    source=("git+https://github.com/Tatsh/kate-wakatime 
<https://github.com/Tatsh/kate-wakatime>")
    md5sums=('SKIP')

    build() {
         cmake -B build -S "kate-wakatime" \
             -DCMAKE_BUILD_TYPE='None' \
             -DCMAKE_INSTALL_PREFIX='/usr' \
             -Wno-dev
         cmake --build build
    }

    check() {
         ctest --test-dir build --output-on-failure
    }

    package() {
         DESTDIR="$pkgdir" cmake --install build
    }

Thank you for considering my request.

--
Frederick Zhang

PGP: 8BFB EA5B 4C44 BFAC C8EC 5F93 1F92 8BE6 0D8B C11D

OpenPGP_signature
Description: OpenPGP digital signature