Howdy, On Mon, Dec 10, 2018 at 11:34:27AM -0500, AUR General wrote:
I can think of a few things wrong with the package. Primarily, why do they both install the /usr/bin/wormhole binary?Per accepted standards for python programs, if it can be built with python3 it must be built and installed with python3. Command-line binaries should *never* care which programming language they are implemented with. The fact that the "magic-wormhole" program also provides a python library is immaterial. I assume its primary use is to run the "wormhole" command. If some other program also needs to import it as a python library rather than use the executable binary interface, and needs to use the python2 version, then it should provide the library *without* providing the binary. It will then be perfectly okay being coinstalled. Additional notes: The (primary) package should continue to be named "magic-wormhole". There is no need for any provides/conflicts/replaces, since python2-magic-wormhole should not be a replacement for the command-line tool. Please use proper line wrapping for extremely long depends arrays, as the current PKGBUILD is difficult to read. The url pointing to PyPI is not very helpful, I recommend using the readthedocs website: https://magic-wormhole.readthedocs.io/en/latest/welcome.html Python packages should use `python setup.py build` in a build() function, rather than going straight to `python setup.py install` in package(). See: https://wiki.archlinux.org/index.php/Python_package_guidelines
So just to make sure, this all boils down to, this shouldn't be a split package, and the probablem with taholafs should be solved by that package maintainer instead of depending on me? Would it be ok to unsplit the package and go back to a python3 only distribution now?
-- Eli Schwartz Bug Wrangler and Trusted User
-- Powered by Arch Linux! I am registered Linux user number 508465: https://linuxcounter.net/user/508465.html get my public PGP key: gpg --keyserver wwwkeys.pgp.net --recv-key 43DDC193 "A sea of green will set us free" Six Feet Under - 420
signature.asc
Description: PGP signature
