I wonder why you have a test program but don't use it in the test() function of your PKGBUILD? Not that this is needed, but as soon as I saw 'test.c', I thought I would find a test() too.
Furthermore, your package looks reasonable to me. 2014-10-04 12:55 GMT-03:00 Jeremy Audet <[email protected]>: > Hi, > > Would anyone be so nice as to review my libgroove package? The current > package [1] and proposed package [2] are both on GitHub. The package is for > a C library, and I am hoping to add a pkg-config config file (libgroove.pc) > to the package. I've never written one of these before, and am worried > about accidentally trashing users' systems. > > [1] https://github.com/Ichimonji10/PKGBUILDs/tree/master/libgroove > [2] > https://github.com/Ichimonji10/PKGBUILDs/tree/libgroove-pkgconfig/libgroove > > — Jeremy "Ichimonji10" Audet > -- - Thiago
