On 22/06, Storm Dragon wrote:
Hi,
The pypump docs say it works for all versions of python, 2.7, through 3.4 I 
think. I made the PKGBUILD using the python3 dependancy because I figure that 
is what most people will have by default. Does this PKGBUILD look ok?
Thanks
Storm

Hey,

It's mostly fine but http git URLs are prefered when possible since many people are behind firewalls that doesn't let the git protocol through.

I'd also prefer it if you remove the _pkgname variable since it's rather useless. The variable name is longer than the variable itself, and it doesn't change so it's largely useless.

--
Sincerely,
 Johannes Löthberg
 PGP Key ID: 3A9D0BB5

Attachment: pgpgpBm8s2NB8.pgp
Description: PGP signature

Reply via email to