On Wed 18 Sep 2013 at 20:00, Rashif Ray Rahman wrote: > On 18 September 2013 06:18, Xyne <[email protected]> wrote: > > Jonathan Steel wrote: > > > >>$_gitname is $srcdir/$_gitname, not $startdir/$_gitname, so it's fine. To > >>double-check I set $SRCDEST to point somewhere else and it builds fine > >>still. > > > > You're right. Looking at the source of makepkg, I see now that all > > functions cd > > into $srcdir. I still prefer the "$srcdir/$_gitname" format as it is > > explicit > > and future-proof, but there is currently no technical reason to do so. > > I was told by at least one pacman dev (can't quite recall who or via > which communication channel) that this practice should not be > obsoleted; we should continue to navigate into $srcdir before doing > anything.
Thanks both, I agree specifically using $srcdir would be clearer/better practice. I'll update my git packages accordingly next time I touch them. -- Jonathan Steel
pgp3K2S6NCAkT.pgp
Description: PGP signature
