Looks good.
--greg.

anshuman wrote:
Hi Geg ,

Please find the updated diff .

Thanks & Regards
Anshuman

----- Original Message ----- From: "Greg Wright" <[EMAIL PROTECTED]>
To: "anshuman" <[EMAIL PROTECTED]>
Cc: <[email protected]>
Sent: Friday, August 17, 2007 11:19 PM
Subject: Re: [Audio-dev] CR: Changes in audio/device for porting Atlas for Windows Mobile 5.0


 #ifdef _DEBUG
+ #ifdef _WINCE
+ HX_TRACE( "Could Not register class\r\n" );
+ #else
 MessageBox(NULL, _T("Could Not register class"), NULL, MB_OK);
- #endif
+ #endif + #endif // _DEBUG
 return(HXR_OUTOFMEMORY);
 }
 m_bClassRegistered = TRUE;
@@ -1362,8 +1409,12 @@
     if (!m_hWnd)
     {
 #ifdef _DEBUG
+#ifdef _WINCE
+ HX_TRACE( "Could Not create messageWindow\r\n" );
+#else
 MessageBox(NULL, _T("Could Not create messageWindow"), NULL, MB_OK);
 #endif
+#endif

Maybe we could just always use HX_TRACE instead of MessageBox to
clean up this code a bit.


Rest looks good.
--greg.


anshuman wrote:
Synopsis:
Multiple changes for porting Atlas for Windows Mobile 5.0

Overview:

- Dont make use of DirectSound for WINCE platforms
- make use of hlxclib includes. - Volume apis are now supported in WINCE
- issue pause on device reset - needed for the wm50 device being used.

Files Added:

auddevlib_wince-500-ppc-arm.pcf

Files Modified:
audio/device/auddevlib_win.pcf
audio/device/platform/win/winaudio.cpp
audio/device/pub/platform/win/winaudio.h


Image Size and Heap Use impact (Client -Only):
None.

Platforms and Profiles Affected:
None Distribution Libraries Affected:
None

Distribution library impact and planned action:
None

Platforms and Profiles Build Verified:
BIF branch   -> helix_restricted
Target(s)      -> wince_wm50_play (new target)
Profile          -> helix-client-wince-wm50 (new profile)
SYSTEM_ID->wince-500-ppc-arm

Branch:
HEAD, hxclient_3_1_0_atlas

Files Attached:
audio_device.diff.txt
auddevlib_wince-500-ppc-arm.pcf

Thanks & Regards
Anshuman


------------------------------------------------------------------------

_______________________________________________
Audio-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/audio-dev




_______________________________________________
Audio-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/audio-dev

Reply via email to