Resend for Arnel. Can anyone take a look?
Thanks!
Junhong
________________________________
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
Sent: Tuesday, April 03, 2007 4:21 PM
To: [EMAIL PROTECTED]
Subject: [Nokia-private-dev] FW: [datatype-restricted-dev] CR:
Emulatordetects memory leak when pressing 'back' after playing a
clipwith audio that is not supported.
There doesn't appear to be a datatype-restricted-dev list. So, I
wasn't sure where to post this.
-Arnel
______________________________________________
From: Periquet Arnel (Nokia-TP-MSW/Dallas)
Sent: Tuesday, April 03, 2007 4:05 PM
To: '[EMAIL PROTECTED]'
Subject: [datatype-restricted-dev] CR: Emulator
detects memory leak when pressing 'back' after playing a clip with audio
that is not supported.
"Nokia submits this code under the terms
of a commercial contribution agreement with RealNetworks, and I am
authorized to contribute this code under said agreement."
Modified by: [EMAIL PROTECTED]
Reviewed by:
Date: 04-03-2007
Project: Datatype-restricted/rm
ErrorId: EHPE-6ZQHW4
Synopsis: Emulator: MediaPlayer crashes
when pressing back after playing a clip with audio that is not
supported.
Playing a Real Media file that has an
audio codec ID='atrc' results in an unsupported codec for that audio
type.
In the test case, an RMF file with
supported video and unsupported audio (codecID='atrc') is played
resulting in partial playback, where only the video plays.
In this scenario, the Real Media format
plugin will allocate a Codec object. However, if the codec is
unsupported, the plugin fails to deallocate that same Codec object. The
observed emulator result, at first glance, looks like a crash when you
press the 'back' button. However, the indication is that some memory
leaked from the Helix engine.
Root Cause: Implementation. This problem
is revealed by testing a Real Media clip with unsupported audio and
looking for unclaimed memory. To my knowledge, this is a new test that
has revealed an old problem.
Files Modified:
Datatype-restricted/rm/audio/common/codec.cpp
Image Size and Heap Use Impact: minimal
Module Release Testing (STIF): All local
cases pass.
Test case(s) Added: No. This is a memory
leak test that is currently manually performed on the emulator.
Memory Leak Check Performed: Yes. No
leaks introduced. One leak removed.
Platforms and Profiles Build Verified:
Helix-client-s60-32-mmf-mdf-dsp
Armv5, winscw
Platforms and Profiles Functionality
Verified:
Helix-client-s60-32-mmf-mdf-dsp
Armv5, winscw
Branch:
HEAD and Hxclient_2_1_0_cayennes
Index: codec.cpp
===================================================================
RCS file:
/cvsroot/rarvcode-audio/common/codec.cpp,v
retrieving revision 1.32
diff -w -u -b -r1.32 codec.cpp
--- codec.cpp 22 Dec 2005 20:10:13
-0000 1.32
+++ codec.cpp 3 Apr 2007 15:28:29
-0000
@@ -647,6 +647,11 @@
}
}
+ if (mLastError != HXR_OK)
+ {
+ FreeCodec();
+ }
+
return mLastError;
}
_______________________________________________
Audio-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/audio-dev
