Hi Eric, Thanks for your instant response. Sorry, it has to be #if 0. After internal CR comments I was testing the changes and forgot to revert it back to #if 0.
I will check in the changes by afternoon, if nobody else has any comments. Thanks, Rajesh. >-----Original Message----- >From: ext Eric Hyche [mailto:[EMAIL PROTECTED] >Sent: Tuesday, April 03, 2007 9:35 AM >To: Rathinasamy Rajesh (Nokia-TP-MSW/Dallas); >[email protected]; [EMAIL PROTECTED] >Subject: RE: [Clientapps-dev] CR: Enabling Audio Effects for >SymbianMMF and fixfor replay of data during audio device taken case > > >Is this #if and comment still applicable? > >+#if 1 >+ // The following code will be enabled later. Disabled due >to error >+in >sdk > > >Rest looks good. > >Eric > >============================================= >Eric Hyche ([EMAIL PROTECTED]) >Technical Lead >RealNetworks, Inc. > >> -----Original Message----- >> From: [EMAIL PROTECTED] >> [mailto:[EMAIL PROTECTED] On Behalf Of >> [EMAIL PROTECTED] >> Sent: Monday, April 02, 2007 7:00 PM >> To: [email protected]; [EMAIL PROTECTED] >> Subject: [Clientapps-dev] CR: Enabling Audio Effects for SymbianMMF >> and fixfor replay of data during audio device taken case >> >> "Nokia submits this code under the terms of a commercial >contribution >> agreement with RealNetworks, and I am authorized to contribute this >> code under said agreement." >> >> Modified by: [EMAIL PROTECTED] >> >> Reviewed by: >> >> Date: 02-Apr-2007 >> >> Project: SymbianMmf >> >> ErrorId: JZHU-6Z2SL8 >> 106-1545 - Audio Effects support for Helix Engine >> >> >> Synopsis: CR: Enabling Audio Effects and fix for >replay of data >> during audio device taken case >> >> For enabling Audio effects on Symbian MMF, there needs to be a >> provision to create cutom interfaces from the devsound. The >following >> CR is not complete in terms of the feature. CR covers most of the >> changes required for enabling the feature. >> >> DevSound is created by MMF Controller and it is stored >in GlobalMgr. >> The Helix Audio session either creates a new instance of dev >sound or >> uses the global dev sound if it is installed on global manager. >> >> Introduced a new build config option >> HELIX_CONFIG_AUDIO_SESSION_STANDALONE. If the build option >is enabled, >> devSound will be created on the same thread as the client core (in >> MMF, it is same as controller thread). >> Absence of the flag will result in devSound being creeated on a >> separate thread and client will access through Symbian Client/Server >> communication (same as existing behaviour) >> >> CR also has the fix for replay of data when audio >device taken error >> is returned. The Replay queue was not flushed during stop of audio >> session. >> >> Current status: >> * The Audio session changes are complete and tested >for ARM side >> and yet to be implemented for DSP. The global usage of dev sound is >> being temporarily removed from build >> (hxmmfbasectrl.cpp) due to a bug in the symbian. >> >> >> Root Cause of the problem: New feature >> >> Files Added: >> platform/symbian/CHXSymbianAudioSession.cpp >> platform/symbian/CHXSymbianAudioSession.h >> platform/symbian/common >> Platform/symbian/common/CHXMMFDevSound.cpp >> Platform/symbian/common/CHXBaseAudioSession.cpp >> Platform/symbian/common/CHXSymbianAudioDevice.cpp >> pub/platform/symbian/CHXBaseAudioSession.h >> pub/platform/symbian/CHXBaseDevSoundObserver.h >> pub/platform/symbian/CHXMMFDevSound.h >> pub/platform/symbian/CHXSymbianAudioDevice.h >> >> Files Modified: >> auddevlib_symbian.pcf >> platform/symbian/audsymbian.cpp >> platform/symbian/audiosvr/audio_svr.cpp >> platform/symbian/audiosvr/audio_svr.h >> platform/symbian/audiosvr/mmf/audio_session-mmf.cpp >> platform/symbian/audiosvr/mmf/audio_session-mmf.h >> pub/platform/symbian/AudDevStatusObserver.h >> pub/platform/symbian/audsymbian.h >> audiocontroller/controllerdll >> audiocontroller/hxmmfaudioctrl.cpp >> audiocontroller/hxmmfaudioctrl.h >> common/Umakefil >> common/hxmmfbasectrl.cpp >> common/hxmmfbasectrl.h >> videocontroller/MmfCtrlDll >> videocontroller/hxmmfctrlimpl.cpp >> pub/platform/symbian/symbian_gm_inst.h >> >> Image Size and Heap Use impact: minor impact >> >> Module Release testing (STIF) : STIF passed for both >audio session >> configurations (Standalone & Server-Client) >> >> Test case(s) Added : No. Existing test cases covers >most of the >> changes. Effects changes needs to be tested with application. >> >> Memory leak check performed : Yes. No new leaks introduced. >> >> MMP Build : Verified MMP build >> >> Platforms and Profiles Build Verified: >> helix-client-s60-32-mmf-mdf-arm >> >> Platforms and Profiles Functionality verified: armv5, winscw >> >> Branch: Head & 210CayS >> <<audio.zip>> <<cvs_diff.txt>> >> >> > > _______________________________________________ Audio-dev mailing list [email protected] http://lists.helixcommunity.org/mailman/listinfo/audio-dev
